Skip to content

Commit 70303fc

Browse files
committed
app/appengine: stop hiding some tested configurations for x repos
The build dashboard can be used to view builds for the main Go repo and other golang.org/x repos. The isUntested invocation was invalid for repos other than the main one, which was causing results for some tested configurations to become hidden (incorrectly replaced by '•'). Larger changes are needed before there's sufficient data to compute the GoBranch value for all repos reliably, so for now, just update the isUntested invocation to apply only for the main repo. This prioritizes the ability to view test results over the ability to see that some builds are intentionally missing because they are configured not to run. Doing both is a part of future work. For golang/go#40290. For golang/go#34744. For golang/go#28643. Change-Id: Id43cb47abacb1036f578efbb8232ae17ad40eca9 Reviewed-on: https://go-review.googlesource.com/c/build/+/244137 Run-TryBot: Dmitri Shuralyov <[email protected]> TryBot-Result: Gobot Gobot <[email protected]> Reviewed-by: Alexander Rakoczy <[email protected]> Reviewed-by: Carlos Amedee <[email protected]>
1 parent 786a227 commit 70303fc

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

app/appengine/ui.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ <h1>Go Dashboard</h1>
120120
{{end}}
121121
{{range $builderName := $.Builders}}
122122
<td class="result{{if (unsupported .)}} unsupported{{end}}">
123-
{{if isUntested $builderName "go" $.Branch ""}}•{{else}}
123+
{{if and (eq $.Repo "go") (isUntested $builderName "go" $.Branch "")}}•{{else}}
124124
{{with $c.Result $builderName $h}}
125125
{{if .BuildingURL}}
126126
<a href="{{.BuildingURL}}"><img src="https://golang.org/favicon.ico" height=16 width=16 border=0></a>

0 commit comments

Comments
 (0)