Skip to content

Commit 6df8b68

Browse files
committed
cmd/cl: defend against msg.Author == nil
Fixes crash on current Gerrit data. Change-Id: I2097fa66afcbf938f880c89891d7d9ed65d843ac Reviewed-on: https://go-review.googlesource.com/12555 Reviewed-by: Andrew Gerrand <[email protected]>
1 parent 67ced7f commit 6df8b68

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

cmd/cl/cl.go

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -290,6 +290,9 @@ func parseCL(ci *gerrit.ChangeInfo) *CL {
290290
explicitReviewer = ""
291291
)
292292
for _, msg := range ci.Messages {
293+
if msg.Author == nil { // happens for Gerrit-generated messages
294+
continue
295+
}
293296
if strings.HasPrefix(msg.Message, "Uploaded patch set ") {
294297
if explicitReviewer == "close" {
295298
explicitReviewer = ""
@@ -386,6 +389,9 @@ func parseCL(ci *gerrit.ChangeInfo) *CL {
386389
// figure out whether the CL is in need of review
387390
// (or else is waiting for the author to do more work).
388391
for _, msg := range ci.Messages {
392+
if msg.Author == nil { // happens for Gerrit-generated messages
393+
continue
394+
}
389395
if cl.Start.IsZero() {
390396
cl.Start = msg.Time.Time()
391397
}

0 commit comments

Comments
 (0)