Skip to content

Commit 6dd253a

Browse files
h9jianggopherbot
authored andcommitted
internal/task: add a step to tag the release candidate
For golang/vscode-go#3500 Change-Id: I257a974f06387a8888e96e645b3dd692e6ab6287 Reviewed-on: https://go-review.googlesource.com/c/build/+/612115 Auto-Submit: Hongxiang Jiang <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
1 parent b655b73 commit 6dd253a

File tree

1 file changed

+13
-2
lines changed

1 file changed

+13
-2
lines changed

internal/task/releasevscodego.go

+13-2
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,9 @@ func (r *ReleaseVSCodeGoTasks) NewPrereleaseDefinition() *wf.Definition {
136136

137137
_ = wf.Task1(wd, "create release milestone and issue", r.createReleaseMilestoneAndIssue, release, wf.After(approved))
138138

139-
_ = wf.Action2(wd, "create release branch", r.createReleaseBranch, release, prerelease, wf.After(approved))
139+
branched := wf.Action2(wd, "create release branch", r.createReleaseBranch, release, prerelease, wf.After(approved))
140+
// TODO(hxjiang): replace empty commit with the branch's head once verified.
141+
_ = wf.Action3(wd, "tag release candidate", r.tag, wf.Const(""), release, prerelease, wf.After(branched))
140142

141143
return wd
142144
}
@@ -270,6 +272,15 @@ func (r *ReleaseVSCodeGoTasks) nextPrereleaseVersion(ctx *wf.TaskContext, releas
270272
return fmt.Sprintf("rc.%v", pre+1), nil
271273
}
272274

275+
func (r *ReleaseVSCodeGoTasks) tag(ctx *wf.TaskContext, commit string, release releaseVersion, prerelease string) error {
276+
tag := fmt.Sprintf("%s-%s", release, prerelease)
277+
if err := r.Gerrit.Tag(ctx, "vscode-go", tag, commit); err != nil {
278+
return err
279+
}
280+
ctx.Printf("tagged commit %s with tag %s", commit, tag)
281+
return nil
282+
}
283+
273284
func isVSCodeGoStableVersion(release releaseVersion, _ string) bool {
274285
return release.Minor%2 == 0
275286
}
@@ -321,7 +332,7 @@ func latestVersion(versions []string, filters ...func(releaseVersion, string) bo
321332
latestRelease := releaseVersion{}
322333
latestPre := ""
323334
for _, v := range versions {
324-
release, prerelease, ok := parseVersion(v);
335+
release, prerelease, ok := parseVersion(v)
325336
if !ok {
326337
continue
327338
}

0 commit comments

Comments
 (0)