Skip to content

Commit 621ef1f

Browse files
committed
cmd/coordinator: add some more checks & logging to debug Rev-less x/tools tries
Change-Id: I2fef2f01991d2942d6d9fd0bb1f335881148bc45 Reviewed-on: https://go-review.googlesource.com/c/build/+/205605 Reviewed-by: Rebecca Stambler <[email protected]>
1 parent 8250df6 commit 621ef1f

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

cmd/coordinator/coordinator.go

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1238,7 +1238,7 @@ func newTrySet(work *apipb.GerritTryWorkItem) *trySet {
12381238
}
12391239
bs, err := newBuild(brev)
12401240
if err != nil {
1241-
log.Printf("can't create build for %q: %v", rev, err)
1241+
log.Printf("can't create x/%s trybot build for go/master commit %s: %v", project, rev, err)
12421242
return nil
12431243
}
12441244
addBuilderToSet(bs, brev)
@@ -1598,6 +1598,10 @@ func newBuild(rev buildgo.BuilderRev) (*buildStatus, error) {
15981598
if !ok {
15991599
return nil, fmt.Errorf("unknown builder type %q", rev.Name)
16001600
}
1601+
if rev.Rev == "" {
1602+
return nil, fmt.Errorf("required field Rev is empty; got %+v", rev)
1603+
}
1604+
16011605
ctx, cancel := context.WithCancel(context.Background())
16021606
return &buildStatus{
16031607
buildID: "B" + randHex(9),

0 commit comments

Comments
 (0)