cmd/gerritbot: use https:// for cloning

heschi · heschi · commit 567a2d21fc07 · 2022-03-16T20:39:05.000Z
GitHub has shut down git:// as of yesterday; see https://github.blog/2021-09-01-improving-git-protocol-security-github/. Looking at https://api.github.com/repos/golang/go, the clone URL should be better. Fixes golang/go#51722. Change-Id: I629d6c8338df1c5633ae4a6a641d57be02e90fc2 Reviewed-on: https://go-review.googlesource.com/c/build/+/393375 Trust: Heschi Kreinick <heschi@google.com> Run-TryBot: Heschi Kreinick <heschi@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
diff --git a/cmd/gerritbot/gerritbot.go b/cmd/gerritbot/gerritbot.go
@@ -659,7 +659,7 @@ func (b *bot) importGerritChangeFromPR(ctx context.Context, pr *github.PullReque
 	if _, err := os.Stat(repoDir); os.IsNotExist(err) {
 		cmds := []*exec.Cmd{
 			exec.Command("git", "clone", "--bare", gerritRepo, repoDir),
-			exec.Command("git", "-C", repoDir, "remote", "add", "github", githubRepo.GetGitURL()),
+			exec.Command("git", "-C", repoDir, "remote", "add", "github", githubRepo.GetCloneURL()),
 		}
 		for _, c := range cmds {
 			if err := runCmd(c); err != nil {

Original file line number	Diff line number	Diff line change
`@@ -659,7 +659,7 @@ func (b bot) importGerritChangeFromPR(ctx context.Context, pr github.PullReque`
`659`	`659`	`if _, err := os.Stat(repoDir); os.IsNotExist(err) {`
`660`	`660`	`cmds := []*exec.Cmd{`
`661`	`661`	`exec.Command("git", "clone", "--bare", gerritRepo, repoDir),`
`662`		`- exec.Command("git", "-C", repoDir, "remote", "add", "github", githubRepo.GetGitURL()),`
	`662`	`+ exec.Command("git", "-C", repoDir, "remote", "add", "github", githubRepo.GetCloneURL()),`
`663`	`663`	`}`
`664`	`664`	`for _, c := range cmds {`
`665`	`665`	`if err := runCmd(c); err != nil {`