Skip to content

Commit 4f35897

Browse files
dmitshurgopherbot
authored andcommitted
cmd/gorebuild: drop "@" prefix in defaultVersions
When arguments are provided to gorebuild, the "@" character can be used to specify a version. Otherwise version selection happens automatically via defaultVersions. Its output are Go versions, no need for any prefix. Fixes the error preventing gorebuild from running when versions are not explicitly provided via arguments: $ gorebuild 18:05:05.812 downloaded https://go.dev/dl/?mode=json&include=all 18:05:05.836 FAIL: unknown version "@go1.21.0" For golang/go#57120. Change-Id: I050bd9d6d12d89b6891c845e686326c87eae5716 Reviewed-on: https://go-review.googlesource.com/c/build/+/517515 Run-TryBot: Dmitri Shuralyov <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Russ Cox <[email protected]> Auto-Submit: Dmitri Shuralyov <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]>
1 parent 4fe8fe2 commit 4f35897

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

cmd/gorebuild/report.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -305,7 +305,7 @@ func defaultVersions(releases []*DLRelease) []string {
305305
// not reproducible
306306
break
307307
}
308-
versions = append(versions, "@"+r.Version)
308+
versions = append(versions, r.Version)
309309
seen[major] = true
310310
if len(seen) == 2 {
311311
break

0 commit comments

Comments
 (0)