Skip to content

Commit 454ff62

Browse files
committed
devapp/owners: add wasm, oauth2 owners, quiet log spam in test
Change-Id: Ief151fa9e23e08505200b32ee0184b526b3ad233 Reviewed-on: https://go-review.googlesource.com/c/build/+/213441 Run-TryBot: Brad Fitzpatrick <[email protected]> TryBot-Result: Gobot Gobot <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]>
1 parent 17a7d87 commit 454ff62

File tree

2 files changed

+27
-0
lines changed

2 files changed

+27
-0
lines changed

devapp/owners/owners_test.go

+12
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,11 @@ package owners
77
import (
88
"bytes"
99
"encoding/json"
10+
"io"
11+
"log"
1012
"net/http"
1113
"net/http/httptest"
14+
"os"
1215
"testing"
1316

1417
"github.com/google/go-cmp/cmp"
@@ -161,6 +164,15 @@ func TestIndex(t *testing.T) {
161164
}
162165

163166
func TestBadRequest(t *testing.T) {
167+
defer func(old io.Writer) { log.SetOutput(old) }(os.Stderr /* TODO: use log.Writer() when Go 1.14 is out */)
168+
var logBuf bytes.Buffer
169+
log.SetOutput(&logBuf)
170+
defer func() {
171+
if t.Failed() {
172+
t.Logf("Log output: %s", &logBuf)
173+
}
174+
}()
175+
164176
req, err := http.NewRequest("POST", "/owners", bytes.NewBufferString("malformed json"))
165177
if err != nil {
166178
t.Fatalf("http.NewRequest: %v", err)

devapp/owners/table.go

+15
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,7 @@ var (
5959
mpvl = gh("mpvl")
6060
mvdan = gh("mvdan")
6161
mwhudson = gh("mwhudson")
62+
neelance = gh("neelance")
6263
r = gh("robpike")
6364
rsc = gh("rsc")
6465
rstambler = gh("stamblerre")
@@ -109,6 +110,11 @@ var entries = map[string]*Entry{
109110
Secondary: []Owner{thanm, cherryyz},
110111
},
111112

113+
"go/misc/wasm": wasmOwners,
114+
"go/cmd/compile/internal/wasm": wasmOwners,
115+
"go/cmd/internal/obj/wasm": wasmOwners,
116+
"go/cmd/link/internal/wasm": wasmOwners,
117+
112118
"go/src/archive/tar": {
113119
Primary: []Owner{joetsai},
114120
},
@@ -618,6 +624,11 @@ var entries = map[string]*Entry{
618624
Primary: []Owner{mikioh, iant},
619625
},
620626

627+
"oauth2": {
628+
Primary: []Owner{bradfitz},
629+
Secondary: []Owner{jbd, cbro},
630+
},
631+
621632
"review": {
622633
Secondary: []Owner{josharian, kevinburke},
623634
},
@@ -681,3 +692,7 @@ var entries = map[string]*Entry{
681692
Secondary: []Owner{cnoellekb, andybons},
682693
},
683694
}
695+
696+
var wasmOwners = &Entry{
697+
Primary: []Owner{neelance, cherryyz},
698+
}

0 commit comments

Comments
 (0)