Skip to content

Commit 305e1e3

Browse files
committed
cmd/releasebot, cmd/release: add 2 more longtest test-only targets
Add support for a linux-386-longtest test-only target. This is the third longtest builder that we have. Both linux-{386,amd64}-longtest targets are passing on master for future Go 1.17 releases, as well as release-branch.go1.16 and release-branch.go1.15 now that CL 288818 is cherry-picked (see backport issues golang/go#45240 and golang/go#45239). Start including them in the release process by default, so that we have more automated test coverage and more information available during the upcoming releases, and in turn can use it to improve the releases and the release process further. Fixes golang/go#29252. Change-Id: I9740c9ce5cae73a3ed9fe320219f1044f5fdcc9a Reviewed-on: https://go-review.googlesource.com/c/build/+/304949 Trust: Dmitri Shuralyov <[email protected]> Reviewed-by: Alexander Rakoczy <[email protected]> Reviewed-by: Carlos Amedee <[email protected]>
1 parent ca461c2 commit 305e1e3

File tree

3 files changed

+14
-3
lines changed

3 files changed

+14
-3
lines changed

cmd/release/release.go

+5
Original file line numberDiff line numberDiff line change
@@ -262,6 +262,11 @@ var builds = []*Build{
262262
},
263263

264264
// Test-only builds.
265+
{
266+
Builder: "linux-386-longtest",
267+
OS: "linux", Arch: "386",
268+
TestOnly: true,
269+
},
265270
{
266271
Builder: "linux-amd64-longtest",
267272
OS: "linux", Arch: "amd64",

cmd/releasebot/main.go

+2-1
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,7 @@ var releaseTargets = []Target{
5959
{Name: "linux-ppc64le"},
6060

6161
// Test-only targets.
62+
{Name: "linux-386-longtest", TestOnly: true},
6263
{Name: "linux-amd64-longtest", TestOnly: true},
6364
{Name: "windows-amd64-longtest", TestOnly: true},
6465
}
@@ -75,7 +76,7 @@ func usage() {
7576
}
7677

7778
var (
78-
skipTestFlag = flag.String("skip-test", "linux-amd64-longtest", "space-separated list of test-only targets to skip (only use if sufficient testing was done elsewhere)")
79+
skipTestFlag = flag.String("skip-test", "", "space-separated list of test-only targets to skip (only use if sufficient testing was done elsewhere)")
7980
)
8081

8182
var (

cmd/releasebot/main_test.go

+7-2
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,10 @@ func TestTargetSelectionPerGoVersion(t *testing.T) {
2323
want []string // Expected release targets.
2424
}{
2525
{
26-
goVer: []string{"go1.16beta1", "go1.16rc1", "go1.16", "go1.16.1"},
26+
goVer: []string{
27+
"go1.17beta1", "go1.17rc1", "go1.17", "go1.17.1",
28+
"go1.16.3",
29+
},
2730
want: []string{
2831
"src",
2932
"linux-386",
@@ -38,12 +41,13 @@ func TestTargetSelectionPerGoVersion(t *testing.T) {
3841
"darwin-arm64", // New to Go 1.16.
3942
"linux-s390x",
4043
"linux-ppc64le",
44+
"linux-386-longtest",
4145
"linux-amd64-longtest",
4246
"windows-amd64-longtest",
4347
},
4448
},
4549
{
46-
goVer: []string{"go1.15.7", "go1.14.14"},
50+
goVer: []string{"go1.15.11"},
4751
want: []string{
4852
"src",
4953
"linux-386",
@@ -57,6 +61,7 @@ func TestTargetSelectionPerGoVersion(t *testing.T) {
5761
"darwin-amd64",
5862
"linux-s390x",
5963
"linux-ppc64le",
64+
"linux-386-longtest",
6065
"linux-amd64-longtest",
6166
"windows-amd64-longtest",
6267
},

0 commit comments

Comments
 (0)