cmd/coordinator: link "ok" results to build logs

Every now and then, it's highly desirable to be able to view build
logs for a build even if it was successful. Those logs are kept as
of CL 198197, but they just haven't been linked. At long last, add
those links to the build dashboard(s)! 🎉

Keep the visual style of "ok" cells the same, aside that the mouse
cursor becomes a hand with an index finger, rather than a text caret.
This means this feature isn't very discoverable, but we can address
that in the future. (I've experimented with giving the "ok" links
an underline, but even a faint underline quickly leads to a large
amount of overwhelming visual noise when there are hundreds of "ok"
cells on many pages.)

Apply the same change to the work-in-progress dashboard V2 page,
to keep it in sync. (There are additional CSS changes to make it
look more consistent with the current build.golang.org dashboard.)

For golang/go#34119.
Updates golang/go#34744.

Change-Id: I27530e4103bbfd10e8cf09ae1a1cfce06c9bd748
Reviewed-on: https://go-review.googlesource.com/c/build/+/340435
Run-TryBot: Dmitri Shuralyov <[email protected]>
TryBot-Result: Go Bot <[email protected]>
Trust: Dmitri Shuralyov <[email protected]>
Reviewed-by: Alexander Rakoczy <[email protected]>

Author: dmitshur

cmd/coordinator/internal/dashboard/dashboard.html

@@ -150,9 +150,12 @@ <h2 class="Dashboard-packageName">{{$.Package.Name}}</h2>
         <td class="Build-desc desc" title="{{$c.Desc}}">{{$c.Desc}}</td>
         {{range $b := $.Builders}}
           {{range $a := .Archs}}
-            <td class="{{if not $a.FirstClass}} unsupported{{end}}" data-builder="{{$a.Name}}">
+            <td class="Build-result {{if not $a.FirstClass}} unsupported{{end}}" data-builder="{{$a.Name}}">
               {{with $c.ResultForBuilder $a.Name}}
-                  {{if .OK}} ok {{end}}
+                  {{if .OK}}
+                    <a class="Build-resultOK" href="https://build.golang.org/log/{{.LogHash}}"
+                      title="Build log of {{$a.Name}} on commit {{shortHash $c.Hash}}.">ok</a>
+                  {{end}}
               {{end}}
             </td>
           {{end}}

cmd/coordinator/internal/dashboard/handler.go

@@ -290,11 +290,21 @@ func formatGitAuthor(name, email string) string {
 }
 
 var templ = template.Must(
-	template.New("dashboard.html").ParseFiles(
+	template.New("dashboard.html").Funcs(template.FuncMap{
+		"shortHash": shortHash,
+	}).ParseFiles(
 		internal.FilePath("dashboard.html", "internal/dashboard", "cmd/coordinator/internal/dashboard"),
 	),
 )
 
+// shortHash returns a short version of a hash.
+func shortHash(hash string) string {
+	if len(hash) > 7 {
+		hash = hash[:7]
+	}
+	return hash
+}
+
 // A Commit describes an individual commit in a package.
 //
 // Each Commit entity is a descendant of its associated Package entity.

cmd/coordinator/internal/legacydash/static/style.css

@@ -203,6 +203,10 @@ table thead tr {
 .build .ok {
   font-size: 83%;
 }
+.build a.ok {
+  color: #000;
+  text-decoration: none;
+}
 
 .build .desc, .build .time, .build .user {
   white-space: nowrap;

cmd/coordinator/internal/legacydash/ui.html

@@ -133,7 +133,8 @@ <h1>
                 {{if .BuildingURL}}
                   <a href="{{.BuildingURL}}"><img src="https://golang.org/favicon.ico" height=16 width=16 border=0></a>
                 {{else if .OK}}
-                  <span class="ok{{if knownIssue $builderName}} noise{{end}}">ok</span>
+                  <a href="/log/{{.LogHash}}" class="ok{{if knownIssue $builderName}} noise{{end}}"
+                    title="Build log of {{$builderName}} on commit {{shortHash $c.Hash}}{{with $h}} (using Go commit {{shortHash .}}){{end}}.">ok</a>
                 {{else if knownIssue $builderName}}
                   <a href="/log/{{.LogHash}}" class="noise" title="Builder {{$builderName}} has a known issue. See golang.org/issue/{{knownIssue $builderName}}.">fail</a>
                 {{else}}
@@ -237,7 +238,8 @@ <h2>
                 {{if .BuildingURL}}
                   <a href="{{.BuildingURL}}"><img src="https://golang.org/favicon.ico" height=16 width=16 border=0></a>
                 {{else if .OK}}
-                  <span class="ok">ok</span>
+                  <a href="/log/{{.LogHash}}" class="ok"
+                    title="Build log of {{$builderName}} on commit {{shortHash $h}} (using Go commit {{shortHash $goHash}}).">ok</a>
                 {{else}}
                   <a href="/log/{{.LogHash}}" class="fail">fail</a>
                 {{end}}

cmd/coordinator/style.css

@@ -111,6 +111,9 @@ table thead tr {
 table.Build tbody tr:nth-child(even) {
   background-color: #f4f4f4;
 }
+table.Build tbody tr.commit:hover {
+  background-color: #ffff99;
+}
 .ShortHash {
   display: inline-block;
   font-family: monospace;
@@ -151,6 +154,7 @@ table.Build tbody tr:nth-child(even) {
   white-space: nowrap;
 }
 .Build-desc {
+  font-size: 0.8125rem;
   max-width: 8.875rem;
   overflow: hidden;
   text-overflow: ellipsis;
@@ -162,8 +166,16 @@ table.Build tbody tr:nth-child(even) {
 }
 .Build-builderArchRow th,
 .Build-builderTagRow th {
-  font-size: 0.5625rem;
+  font-size: 0.625rem;
   font-weight: normal;
   text-align: center;
   white-space: nowrap;
 }
+.Build-result {
+  text-align: center;
+}
+.Build-resultOK {
+  font-size: 0.6875rem;
+  color: #000;
+  text-decoration: none;
+}