Skip to content

Commit 297480d

Browse files
cherrymuibradfitz
authored andcommitted
cmd/release: set CGO_{C,LD}FLAGS if GOARM is set
So it really builds an ARMv6 binary when GOARM=6. Tried "release -rev go1.8rc2 -tools release-branch.go1.8 -version go1.8rc2 -target linux-armv6l -watch" and the generated binary works on my Raspberry Pi 1. Fixes golang/go#18748. Change-Id: I11113f98703049dc9990fe8c8abf505dcfd980f2 Reviewed-on: https://go-review.googlesource.com/35501 Reviewed-by: Brad Fitzpatrick <[email protected]>
1 parent 409147c commit 297480d

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

cmd/release/release.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -348,6 +348,8 @@ func (b *Build) make() error {
348348

349349
if b.Goarm > 0 {
350350
env = append(env, fmt.Sprintf("GOARM=%d", b.Goarm))
351+
env = append(env, fmt.Sprintf("CGO_CFLAGS=-march=armv%d", b.Goarm))
352+
env = append(env, fmt.Sprintf("CGO_LDFLAGS=-march=armv%d", b.Goarm))
351353
}
352354

353355
// Execute build

0 commit comments

Comments
 (0)