Skip to content

Commit 240bc6e

Browse files
cybrcodrbradfitz
authored andcommitted
dashboard: remove no longer used build configs for android and ios.
Also, remove logic in addBuilder that sets HostType for mobile configs. Change-Id: Id87f885fb56887abf52f656d06981f5b36b73310 Reviewed-on: https://go-review.googlesource.com/52634 Reviewed-by: Tuo Shan <[email protected]> Reviewed-by: Brad Fitzpatrick <[email protected]>
1 parent db4f528 commit 240bc6e

File tree

1 file changed

+0
-49
lines changed

1 file changed

+0
-49
lines changed

dashboard/builders.go

Lines changed: 0 additions & 49 deletions
Original file line numberDiff line numberDiff line change
@@ -1087,38 +1087,6 @@ func init() {
10871087
Name: "darwin-amd64-10_12",
10881088
HostType: "host-darwin-10_12",
10891089
})
1090-
1091-
addBuilder(BuildConfig{
1092-
Name: "android-arm-sdk19",
1093-
Notes: "Android ARM device running android-19 (KitKat 4.4), attatched to Mac Mini",
1094-
env: []string{"GOOS=android", "GOARCH=arm"},
1095-
})
1096-
addBuilder(BuildConfig{
1097-
Name: "android-arm64-sdk21",
1098-
Notes: "Android arm64 device using the android-21 toolchain, attatched to Mac Mini",
1099-
env: []string{"GOOS=android", "GOARCH=arm64"},
1100-
})
1101-
addBuilder(BuildConfig{
1102-
Name: "android-386-sdk21",
1103-
Notes: "Android 386 device using the android-21 toolchain, attatched to Mac Mini",
1104-
env: []string{"GOOS=android", "GOARCH=386"},
1105-
})
1106-
addBuilder(BuildConfig{
1107-
Name: "android-amd64-sdk21",
1108-
Notes: "Android amd64 device using the android-21 toolchain, attatched to Mac Mini",
1109-
env: []string{"GOOS=android", "GOARCH=amd64"},
1110-
})
1111-
addBuilder(BuildConfig{
1112-
Name: "darwin-arm-a5ios",
1113-
Notes: "iPhone 4S (A5 processor), via a Mac Mini; owned by crawshaw",
1114-
env: []string{"GOARCH=arm", "GOHOSTARCH=amd64"},
1115-
})
1116-
addBuilder(BuildConfig{
1117-
Name: "darwin-arm64-a7ios",
1118-
Notes: "iPad Mini 3 (A7 processor), via a Mac Mini; owned by crawshaw",
1119-
env: []string{"GOARCH=arm64", "GOHOSTARCH=amd64"},
1120-
})
1121-
11221090
addBuilder(BuildConfig{
11231091
Name: "darwin-arm-a1549ios",
11241092
HostType: "host-darwin-amd64-eliasnaur-ios",
@@ -1150,7 +1118,6 @@ func init() {
11501118
"CC_FOR_TARGET=/Users/elias/android-ndk-standalone-arm64/bin/clang",
11511119
},
11521120
})
1153-
11541121
addBuilder(BuildConfig{
11551122
Name: "solaris-amd64-oracledev",
11561123
HostType: "host-solaris-oracle-shawn",
@@ -1231,28 +1198,12 @@ func init() {
12311198
})
12321199
}
12331200

1234-
func (c BuildConfig) isMobile() bool {
1235-
return strings.HasPrefix(c.Name, "android-") || strings.HasPrefix(c.Name, "darwin-arm")
1236-
}
1237-
12381201
// addBuilder adds c to the Builders map after doing some sanity
12391202
// checks.
12401203
func addBuilder(c BuildConfig) {
12411204
if c.Name == "" {
12421205
panic("empty name")
12431206
}
1244-
if c.isMobile() && c.HostType == "" {
1245-
htyp := "host-" + c.Name
1246-
if _, ok := Hosts[htyp]; !ok {
1247-
Hosts[htyp] = &HostConfig{
1248-
HostType: htyp,
1249-
IsReverse: true,
1250-
goBootstrapURLTmpl: "https://storage.googleapis.com/$BUCKET/go1.4-darwin-amd64.tar.gz",
1251-
ReverseAliases: []string{c.Name},
1252-
}
1253-
c.HostType = htyp
1254-
}
1255-
}
12561207
if c.HostType == "" {
12571208
panic(fmt.Sprintf("missing HostType for builder %q", c.Name))
12581209
}

0 commit comments

Comments
 (0)