Skip to content

Commit 1ddff20

Browse files
dmitshurgopherbot
authored andcommitted
cmd/gorebuild: check uid/gid/uname/gname/mtime fields in tgz files
Issue 61513 is resolved so this path can be turned on now. Confirmed to still pass now that go1.21rc4 is out. It was the first release built using improvements from CL 512437. For golang/go#57120. For golang/go#58884. For golang/go#61513. Change-Id: Ie39765f8c7ba514dea2bfccf7c8ef8acc5822a22 Reviewed-on: https://go-review.googlesource.com/c/build/+/515415 TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Russ Cox <[email protected]> Auto-Submit: Russ Cox <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Run-TryBot: Dmitri Shuralyov <[email protected]>
1 parent a448232 commit 1ddff20

File tree

1 file changed

+5
-7
lines changed

1 file changed

+5
-7
lines changed

cmd/gorebuild/io.go

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -481,13 +481,11 @@ func DiffTarGz(log *Log, rebuilt, posted []byte, fix Fixer) bool {
481481
field("typeflag", r.Typeflag, p.Typeflag)
482482
field("linkname", r.Linkname, p.Linkname)
483483
field("mode", r.Mode, p.Mode)
484-
if false { // TODO enable these after #61513 is fixed
485-
field("uid", r.Uid, p.Uid)
486-
field("gid", r.Gid, p.Gid)
487-
field("uname", r.Uname, p.Uname)
488-
field("gname", r.Gname, p.Gname)
489-
field("mtime", r.ModTime, p.ModTime)
490-
}
484+
field("uid", r.Uid, p.Uid)
485+
field("gid", r.Gid, p.Gid)
486+
field("uname", r.Uname, p.Uname)
487+
field("gname", r.Gname, p.Gname)
488+
field("mtime", r.ModTime, p.ModTime)
491489
field("atime", r.AccessTime, p.AccessTime)
492490
field("ctime", r.ChangeTime, p.ChangeTime)
493491
field("devmajor", r.Devmajor, p.Devmajor)

0 commit comments

Comments
 (0)