all: switch to newer, preferred API for BuildBucket API clients

The PRPCClient variant is generated by a custom plugin and predates
the raw Client variant, which is preferred in newer code. Switch to
it before doing more to understand the previously-mentioned strange
intermittent issue of queries sometimes taking an extra 24 hours to
successfully complete.

For golang/go#65913.

Change-Id: Ibb8495a939bb80f445261cddda9d900c82ec7e62
Reviewed-on: https://go-review.googlesource.com/c/build/+/574556
Reviewed-by: Michael Knyszek <[email protected]>
Auto-Submit: Dmitri Shuralyov <[email protected]>
LUCI-TryBot-Result: Go LUCI <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>

Author: dmitshur

cmd/coordinator/coordinator.go

@@ -380,11 +380,11 @@ func main() {
 			log.Fatalln("luci/auth.NewAuthenticator:", err)
 		}
 	}
-	buildersCl := buildbucketpb.NewBuildersPRPCClient(&prpc.Client{
+	buildersCl := buildbucketpb.NewBuildersClient(&prpc.Client{
 		C:    luciHTTPClient,
 		Host: "cr-buildbucket.appspot.com",
 	})
-	buildsCl := buildbucketpb.NewBuildsPRPCClient(&prpc.Client{
+	buildsCl := buildbucketpb.NewBuildsClient(&prpc.Client{
 		C:    luciHTTPClient,
 		Host: "cr-buildbucket.appspot.com",
 	})

cmd/relui/main.go

@@ -181,11 +181,11 @@ func main() {
 	if err != nil {
 		log.Fatal(err)
 	}
-	buildsClient := pb.NewBuildsPRPCClient(&prpc.Client{
+	buildsClient := pb.NewBuildsClient(&prpc.Client{
 		C:    luciHTTPClient,
 		Host: "cr-buildbucket.appspot.com",
 	})
-	buildersClient := pb.NewBuildersPRPCClient(&prpc.Client{
+	buildersClient := pb.NewBuildersClient(&prpc.Client{
 		C:    luciHTTPClient,
 		Host: "cr-buildbucket.appspot.com",
 	})

cmd/watchflakes/luci.go

@@ -47,15 +47,15 @@ func NewLUCIClient() *LUCIClient {
 	if err != nil {
 		log.Fatal(err)
 	}
-	buildsClient := bbpb.NewBuildsPRPCClient(&prpc.Client{
+	buildsClient := bbpb.NewBuildsClient(&prpc.Client{
 		C:    c,
 		Host: crBuildBucketHost,
 	})
-	buildersClient := bbpb.NewBuildersPRPCClient(&prpc.Client{
+	buildersClient := bbpb.NewBuildersClient(&prpc.Client{
 		C:    c,
 		Host: crBuildBucketHost,
 	})
-	resultDBClient := rdbpb.NewResultDBPRPCClient(&prpc.Client{
+	resultDBClient := rdbpb.NewResultDBClient(&prpc.Client{
 		C:    c,
 		Host: resultDBHost,
 	})

internal/relui/workflows_test.go

@@ -198,7 +198,7 @@ func TestReadRelevantBuildersLive(t *testing.T) {
 	if err != nil {
 		t.Fatal("auth.NewAuthenticator:", err)
 	}
-	buildersClient := buildbucketpb.NewBuildersPRPCClient(&prpc.Client{
+	buildersClient := buildbucketpb.NewBuildersClient(&prpc.Client{
 		C:    luciHTTPClient,
 		Host: "cr-buildbucket.appspot.com",
 	})

internal/task/tagx_test.go

@@ -155,11 +155,11 @@ func TestFindMissingBuildersLive(t *testing.T) {
 	if err != nil {
 		t.Fatal("auth.NewAuthenticator:", err)
 	}
-	buildsClient := buildbucketpb.NewBuildsPRPCClient(&prpc.Client{
+	buildsClient := buildbucketpb.NewBuildsClient(&prpc.Client{
 		C:    luciHTTPClient,
 		Host: "cr-buildbucket.appspot.com",
 	})
-	buildersClient := buildbucketpb.NewBuildersPRPCClient(&prpc.Client{
+	buildersClient := buildbucketpb.NewBuildersClient(&prpc.Client{
 		C:    luciHTTPClient,
 		Host: "cr-buildbucket.appspot.com",
 	})