internal/iapclient: remove dead scopes

gomoteConfig.Scopes is not reachable anymore, only the scopes in login
are used. To avoid confusion, move those scopes into gomoteConfig and
change login to use gomoteConfig.Scopes.

Change-Id: I2172983468bb8a565c180994e40580af99f426d7
Reviewed-on: https://go-review.googlesource.com/c/build/+/461960
Run-TryBot: Michael Pratt <[email protected]>
Reviewed-by: Heschi Kreinick <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>

Author: prattmic

internal/iapclient/iapclient.go

@@ -37,13 +37,13 @@ var gomoteConfig = &oauth2.Config{
 	ClientID:     "872405196845-odamr0j3kona7rp7fima6h4ummnd078t.apps.googleusercontent.com",
 	ClientSecret: "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",
 	Endpoint:     google.Endpoint,
-	Scopes:       []string{"openid email"},
+	Scopes:       []string{"email openid profile"},
 }
 
 func login(ctx context.Context) (*oauth2.Token, error) {
 	resp, err := http.PostForm("https://oauth2.googleapis.com/device/code", url.Values{
 		"client_id": []string{gomoteConfig.ClientID},
-		"scope":     []string{"email openid profile"},
+		"scope":     gomoteConfig.Scopes,
 	})
 	if err != nil {
 		return nil, err