Skip to content

Commit 10d5d32

Browse files
committed
dashboard: add windows-arm64 builder
Add the windows-arm64 builder to the dashboard and coordinator with a known issue until we can verify builds are succeeding regularly. Also, tweak the logic around validating ec2 configurations. The arm64 buildlet sets VMImage but not ContainerImage, unlike other ec2 buildlets. This should work for both. For golang/go#42604 Change-Id: I7176b8f6bba837830a0565e7713c9e9a0eb76e90 Reviewed-on: https://go-review.googlesource.com/c/build/+/322656 Trust: Alexander Rakoczy <[email protected]> Run-TryBot: Alexander Rakoczy <[email protected]> TryBot-Result: Go Bot <[email protected]> Reviewed-by: Carlos Amedee <[email protected]>
1 parent 214f252 commit 10d5d32

File tree

1 file changed

+21
-2
lines changed

1 file changed

+21
-2
lines changed

dashboard/builders.go

Lines changed: 21 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -473,6 +473,16 @@ var Hosts = map[string]*HostConfig{
473473
OwnerGithub: "zx2c4",
474474
env: []string{"GOROOT_BOOTSTRAP=C:\\Program Files (Arm)\\Go"},
475475
},
476+
"host-windows-arm64-qemu": &HostConfig{
477+
Notes: "Ubuntu hosting Windows 10 in qemu with KVM, EC2 ARM64 instance. See x/build/env/windows-arm64/aws",
478+
VMImage: "ami-0203852dc6efbfb68",
479+
SSHUsername: "gopher", // Windows username is gopher, linux is ubuntu.
480+
buildletURLTmpl: "http://storage.googleapis.com/$BUCKET/buildlet.windows-arm64",
481+
env: []string{"GOARCH=arm64"},
482+
goBootstrapURLTmpl: "https://storage.googleapis.com/$BUCKET/gobootstrap-windows-arm64-f22ec5.tar.gz",
483+
isEC2: true,
484+
machineType: "a1.metal",
485+
},
476486
"host-darwin-10_12": &HostConfig{
477487
IsReverse: true,
478488
ExpectNum: 3,
@@ -695,10 +705,10 @@ func init() {
695705
panic(fmt.Sprintf("HostType %q != key %q", c.HostType, key))
696706
}
697707
nSet := 0
698-
if c.VMImage != "" && !c.isEC2 {
708+
if c.VMImage != "" {
699709
nSet++
700710
}
701-
if c.ContainerImage != "" {
711+
if c.ContainerImage != "" && !c.isEC2 {
702712
nSet++
703713
}
704714
if c.IsReverse {
@@ -2305,6 +2315,15 @@ func init() {
23052315
"GOARM=7",
23062316
"GO_TEST_TIMEOUT_SCALE=3"},
23072317
})
2318+
addBuilder(BuildConfig{
2319+
Name: "windows-arm64-aws",
2320+
HostType: "host-windows-arm64-qemu",
2321+
numTryTestHelpers: 1,
2322+
buildsRepo: func(repo, branch, goBranch string) bool {
2323+
return atLeastGo1(goBranch, 17) && buildRepoByDefault(repo)
2324+
},
2325+
KnownIssue: 42604,
2326+
})
23082327
addBuilder(BuildConfig{
23092328
Name: "darwin-amd64-10_12",
23102329
HostType: "host-darwin-10_12",

0 commit comments

Comments
 (0)