Skip to content

Commit 0a4bf69

Browse files
committed
dashboard: shard openbsd-amd64-68 TryBot also
The goal in CL 279512 was to reduce numTryTestHelpers from 5 to 4, but it unintentionally set the field only in the 386 builder, not the amd64 one. This caused the amd64 OpenBSD TryBot to get very slow (20-25 minutes), making it very much a bottleneck for overall TryBot completion time. Also stop explicitly setting some fields in openbsd-amd64-62 builder that have no effect by now, to simplify configuration. For golang/go#17104. Updates golang/go#35712. Change-Id: I22823e4848cab65f11bde2a1cc70527929d0792d Reviewed-on: https://go-review.googlesource.com/c/build/+/279723 Trust: Dmitri Shuralyov <[email protected]> Run-TryBot: Dmitri Shuralyov <[email protected]> TryBot-Result: Go Bot <[email protected]> Reviewed-by: Alexander Rakoczy <[email protected]>
1 parent 7d700e0 commit 0a4bf69

File tree

1 file changed

+5
-7
lines changed

1 file changed

+5
-7
lines changed

dashboard/builders.go

+5-7
Original file line numberDiff line numberDiff line change
@@ -2019,14 +2019,11 @@ func init() {
20192019
Name: "openbsd-amd64-62",
20202020
HostType: "host-openbsd-amd64-62",
20212021
distTestAdjust: noTestDirAndNoReboot,
2022-
tryBot: nil,
20232022
buildsRepo: func(repo, branch, goBranch string) bool {
20242023
// This builder is unfortunately still used by Go 1.15 and 1.14,
20252024
// so keep it around a bit longer. See golang.org/issue/42426.
20262025
return atMostGo1(goBranch, 15) && buildRepoByDefault(repo)
20272026
},
2028-
numTestHelpers: 0,
2029-
numTryTestHelpers: 5,
20302027
})
20312028
addBuilder(BuildConfig{
20322029
Name: "openbsd-amd64-64",
@@ -2040,10 +2037,11 @@ func init() {
20402037
distTestAdjust: noTestDirAndNoReboot,
20412038
})
20422039
addBuilder(BuildConfig{
2043-
Name: "openbsd-amd64-68",
2044-
HostType: "host-openbsd-amd64-68",
2045-
tryBot: defaultTrySet(),
2046-
distTestAdjust: noTestDirAndNoReboot,
2040+
Name: "openbsd-amd64-68",
2041+
HostType: "host-openbsd-amd64-68",
2042+
tryBot: defaultTrySet(),
2043+
distTestAdjust: noTestDirAndNoReboot,
2044+
numTryTestHelpers: 4,
20472045
})
20482046
addBuilder(BuildConfig{
20492047
Name: "openbsd-386-68",

0 commit comments

Comments
 (0)