devapp/owners: add platform owners to owners endpoint

The owners HTTP endpoint will now include the platform owners
information. This enables the querying of platform owners when a
broken LUCI bot is detected.

For golang/go#68790

Change-Id: I7a69f1cbb8db55db7369cf97bec41c8eedfbea3c
Reviewed-on: https://go-review.googlesource.com/c/build/+/646837
LUCI-TryBot-Result: Go LUCI <[email protected]>
Reviewed-by: Michael Pratt <[email protected]>

Author: cagedmantis

devapp/owners/owners.go

@@ -60,13 +60,18 @@ type Request struct {
 		//
 		// If All is true, Paths must be empty.
 		All bool `json:"all"`
+
+		// Platform indicates that the response should contain all platform
+		// owners entries.
+		Platform bool `json:"platform"`
 	} `json:"payload"`
 	Version int `json:"v"` // API version
 }
 
 type Response struct {
 	Payload struct {
-		Entries map[string]*Entry `json:"entries"` // paths in request -> Entry
+		Entries   map[string]*Entry `json:"entries"`   // paths in request -> Entry
+		Platforms map[string]*Entry `json:"platforms"` // platforms (GOOS or GOARCH) -> Entry
 	} `json:"payload"`
 	Error string `json:"error,omitempty"`
 }
@@ -133,14 +138,18 @@ func Handler(w http.ResponseWriter, r *http.Request) {
 		var resp Response
 		if req.Payload.All {
 			resp.Payload.Entries = entries
+			resp.Payload.Platforms = archOses
 		} else {
 			resp.Payload.Entries = make(map[string]*Entry)
 			for _, p := range req.Payload.Paths {
 				resp.Payload.Entries[p] = match(p)
 			}
+			if req.Payload.Platform {
+				resp.Payload.Platforms = archOses
+			}
 		}
-		// resp.Payload.Entries must not be mutated because it contains
-		// references to the global "entries" value.
+		// resp.Payload.Entries and resp.Payload.Platforms must not be mutated because they
+		// contain references to the global "entries" and "archOses" values.
 
 		var buf bytes.Buffer
 		if err := json.NewEncoder(&buf).Encode(resp); err != nil {

devapp/owners/owners_test.go

@@ -64,26 +64,44 @@ func TestMatch(t *testing.T) {
 }
 
 func TestHandler(t *testing.T) {
+	copyEntries := func(m map[string]*Entry) map[string]*Entry {
+		out := make(map[string]*Entry)
+		for k, v := range m {
+			e := &Entry{
+				Primary: v.Primary,
+			}
+			if len(v.Secondary) != 0 {
+				e.Secondary = v.Secondary
+			}
+			out[k] = e
+		}
+		return out
+	}
+
 	testCases := []struct {
-		method  string
-		code    int
-		paths   []string
-		entries map[string]*Entry
+		method    string
+		code      int
+		all       bool
+		paths     []string
+		entries   map[string]*Entry
+		platforms map[string]*Entry
 	}{
-		{"PUT", http.StatusMethodNotAllowed, nil, nil},
-		{"OPTIONS", http.StatusOK, nil, nil},
+		{"PUT", http.StatusMethodNotAllowed, false, nil, nil, nil},
+		{"OPTIONS", http.StatusOK, false, nil, nil, nil},
 		{
-			"POST", http.StatusOK,
+			"POST", http.StatusOK, false,
 			[]string{"nonexistent/path"},
 			map[string]*Entry{"nonexistent/path": nil},
+			nil,
 		},
 		{
-			"POST", http.StatusOK,
+			"POST", http.StatusOK, false,
 			[]string{"go/src/archive/zip/a.go"},
 			map[string]*Entry{"go/src/archive/zip/a.go": {Primary: []Owner{joetsai}, Secondary: []Owner{bradfitz}}},
+			nil,
 		},
 		{
-			"POST", http.StatusOK,
+			"POST", http.StatusOK, false,
 			[]string{
 				"go/src/archive/zip/a.go",
 				"go/src/archive/zip/b.go",
@@ -92,9 +110,22 @@ func TestHandler(t *testing.T) {
 				"go/src/archive/zip/a.go": {Primary: []Owner{joetsai}, Secondary: []Owner{bradfitz}},
 				"go/src/archive/zip/b.go": {Primary: []Owner{joetsai}, Secondary: []Owner{bradfitz}},
 			},
+			nil,
+		},
+		{
+			"POST", http.StatusOK, false,
+			[]string{
+				"go/src/archive/zip/a.go",
+				"crypto/chacha20poly1305/chacha20poly1305.go",
+			},
+			map[string]*Entry{
+				"go/src/archive/zip/a.go":                     {Primary: []Owner{joetsai}, Secondary: []Owner{bradfitz}},
+				"crypto/chacha20poly1305/chacha20poly1305.go": {Primary: []Owner{filippo, roland, securityTeam}},
+			},
+			nil,
 		},
 		{
-			"POST", http.StatusOK,
+			"POST", http.StatusOK, false,
 			[]string{
 				"go/src/archive/zip/a.go",
 				"crypto/chacha20poly1305/chacha20poly1305.go",
@@ -103,14 +134,25 @@ func TestHandler(t *testing.T) {
 				"go/src/archive/zip/a.go":                     {Primary: []Owner{joetsai}, Secondary: []Owner{bradfitz}},
 				"crypto/chacha20poly1305/chacha20poly1305.go": {Primary: []Owner{filippo, roland, securityTeam}},
 			},
+			archOses,
+		},
+		{
+			"POST", http.StatusOK, true,
+			[]string{},
+			copyEntries(entries),
+			archOses,
 		},
 	}
 
 	for _, tc := range testCases {
 		var buf bytes.Buffer
 		if tc.paths != nil {
 			var oReq Request
+			oReq.Payload.All = tc.all
 			oReq.Payload.Paths = tc.paths
+			if len(tc.platforms) > 0 {
+				oReq.Payload.Platform = true
+			}
 			if err := json.NewEncoder(&buf).Encode(oReq); err != nil {
 				t.Errorf("could not encode request: %v", err)
 				continue
@@ -146,6 +188,9 @@ func TestHandler(t *testing.T) {
 		if diff := cmp.Diff(oResp.Payload.Entries, tc.entries); diff != "" {
 			t.Errorf("%s: (-got +want)\n%s", tc.method, diff)
 		}
+		if diff := cmp.Diff(oResp.Payload.Platforms, tc.platforms); diff != "" {
+			t.Errorf("%s: (-got +want)\n%s", tc.method, diff)
+		}
 	}
 }