Skip to content

Commit 5c007b3

Browse files
dmitshurgopherbot
authored andcommitted
sweet/harnesses: stop trimming "devel " prefix from Go version
The "devel " prefix is no more as of CL 668015. It's still present as a substring, making it a https://go.dev/doc/toolchain#name compatible format (a "non-standard toolchain"). For golang/go#73369. Change-Id: I86693562119bf7ec8f61a2fab902b29ceaefede3 Reviewed-on: https://go-review.googlesource.com/c/benchmarks/+/669215 LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Michael Pratt <[email protected]> Auto-Submit: Dmitri Shuralyov <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]>
1 parent 5d13331 commit 5c007b3

File tree

1 file changed

+0
-8
lines changed

1 file changed

+0
-8
lines changed

sweet/harnesses/go-build.go

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ import (
1010
"go/version"
1111
"os/exec"
1212
"path/filepath"
13-
"strings"
1413

1514
"golang.org/x/benchmarks/sweet/common"
1615
"golang.org/x/benchmarks/sweet/common/fileutil"
@@ -204,13 +203,6 @@ func goBuildBenchmarks(cfg *common.Config, short bool) ([]*buildBenchmark, error
204203
if err != nil {
205204
return nil, fmt.Errorf("error reading build info from Go toolchain: %v", err)
206205
}
207-
208-
// NOTE(go.dev/issue/73369): Tip toolchain versions look like
209-
// "devel go1.25-9ce47e66e8 Wed Mar 26 03:48:50 2025 -0700".
210-
// This is not a valid go/version version, so it sorts before
211-
// every valid version. If we strip "devel", then the remainder
212-
// is valid.
213-
bi.GoVersion = strings.TrimPrefix(bi.GoVersion, "devel ")
214206
}
215207

216208
base := buildBenchmarks

0 commit comments

Comments
 (0)