From 21b2759739ef82cb1a7f033b49b1474d5b5ac064 Mon Sep 17 00:00:00 2001 From: Christian Banse Date: Fri, 28 May 2021 10:54:06 +0200 Subject: [PATCH 1/8] Providing full test matrix in GitHub actions Starting with Go 1.7, since this is the lowest version still working, once we merge in #12. We can then gradually move upwards. --- .github/workflows/build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 7be10e46..3dbd487a 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -12,7 +12,7 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - go: [1.14, 1.15, 1.16] + go: [1.7, 1.8, 1.9, 1.10, 1.11, 1.12, 1.13, 1.14, 1.15, 1.16] steps: - name: Checkout uses: actions/checkout@v2 From d37e46ffa4813bd316b2cd886ea0c817c08441b9 Mon Sep 17 00:00:00 2001 From: Christian Banse Date: Fri, 28 May 2021 10:54:35 +0200 Subject: [PATCH 2/8] Delete .travis.yml --- .travis.yml | 13 ------------- 1 file changed, 13 deletions(-) delete mode 100644 .travis.yml diff --git a/.travis.yml b/.travis.yml deleted file mode 100644 index 1027f56c..00000000 --- a/.travis.yml +++ /dev/null @@ -1,13 +0,0 @@ -language: go - -script: - - go vet ./... - - go test -v ./... - -go: - - 1.3 - - 1.4 - - 1.5 - - 1.6 - - 1.7 - - tip From 57c6f7d1bd7a4e1c2efd94d16eb2972cae90f8fe Mon Sep 17 00:00:00 2001 From: Christian Banse Date: Fri, 28 May 2021 11:01:33 +0200 Subject: [PATCH 3/8] Fixed build for non-modules --- .github/workflows/build.yml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 3dbd487a..78538b06 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -16,6 +16,9 @@ jobs: steps: - name: Checkout uses: actions/checkout@v2 + with: + fetch-depth: 1 + path: go/github.com/dgrijalva/jwt-go # needs to be set until we drop Go versions without module support - name: Setup Go uses: actions/setup-go@v2 with: @@ -25,3 +28,5 @@ jobs: go vet ./... go test -v ./... go build ./... + env: + GOPATH: go From 0275455adfe34e9f87e1686d6b9dbea03052c2a4 Mon Sep 17 00:00:00 2001 From: Christian Banse Date: Fri, 28 May 2021 11:05:25 +0200 Subject: [PATCH 4/8] Update build.yml --- .github/workflows/build.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 78538b06..f51db24c 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -22,11 +22,11 @@ jobs: - name: Setup Go uses: actions/setup-go@v2 with: - go-version: ${{ matrix.go }} + go-version: "${{ matrix.go }}" - name: Build run: | go vet ./... go test -v ./... go build ./... env: - GOPATH: go + GOPATH: /home/runner/work/jwt/jwt/go From 3e643b809d065f90713e5b5fbaba21c375f02675 Mon Sep 17 00:00:00 2001 From: Christian Banse Date: Fri, 28 May 2021 11:10:11 +0200 Subject: [PATCH 5/8] Update build.yml --- .github/workflows/build.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index f51db24c..a0b9b81a 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -12,13 +12,13 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - go: [1.7, 1.8, 1.9, 1.10, 1.11, 1.12, 1.13, 1.14, 1.15, 1.16] + go: [1.7, 1.8, 1.9, 1.11, 1.12, 1.13, 1.14, 1.15, 1.16] # 1.10 does not work somehow steps: - name: Checkout uses: actions/checkout@v2 with: fetch-depth: 1 - path: go/github.com/dgrijalva/jwt-go # needs to be set until we drop Go versions without module support + path: go/src/github.com/dgrijalva/jwt-go # needs to be set until we drop Go versions without module support - name: Setup Go uses: actions/setup-go@v2 with: @@ -29,4 +29,4 @@ jobs: go test -v ./... go build ./... env: - GOPATH: /home/runner/work/jwt/jwt/go + GOPATH: /home/runner/work/jwt/jwt/go # needs to be set until we drop Go versions without module support From c4264c4173ac12ab3cb38931c2404dc6ad306d39 Mon Sep 17 00:00:00 2001 From: "Banse, Christian" Date: Fri, 28 May 2021 11:18:13 +0200 Subject: [PATCH 6/8] Only testing Go version with module support on GitHub actions --- .github/workflows/build.yml | 7 +------ .travis.yml | 18 ++++++++++++++++++ 2 files changed, 19 insertions(+), 6 deletions(-) create mode 100644 .travis.yml diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index a0b9b81a..de940f03 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -12,13 +12,10 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - go: [1.7, 1.8, 1.9, 1.11, 1.12, 1.13, 1.14, 1.15, 1.16] # 1.10 does not work somehow + go: [1.11, 1.12, 1.13, 1.14, 1.15, 1.16] steps: - name: Checkout uses: actions/checkout@v2 - with: - fetch-depth: 1 - path: go/src/github.com/dgrijalva/jwt-go # needs to be set until we drop Go versions without module support - name: Setup Go uses: actions/setup-go@v2 with: @@ -28,5 +25,3 @@ jobs: go vet ./... go test -v ./... go build ./... - env: - GOPATH: /home/runner/work/jwt/jwt/go # needs to be set until we drop Go versions without module support diff --git a/.travis.yml b/.travis.yml new file mode 100644 index 00000000..3ac7240d --- /dev/null +++ b/.travis.yml @@ -0,0 +1,18 @@ +language: go + +script: + - go vet ./... + - go test -v ./... + +go: + - 1.7 + - 1.8 + - 1.9 + - 1.10 + - 1.11 + - 1.12 + - 1.13 + - 1.14 + - 1.15 + - 1.16 + - tip From 8fcfff0baaf45e12931807cdd3e3d0245c54ac75 Mon Sep 17 00:00:00 2001 From: "Banse, Christian" Date: Fri, 28 May 2021 11:19:52 +0200 Subject: [PATCH 7/8] Do not fail fast --- .github/workflows/build.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index de940f03..9a90eba1 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -11,6 +11,7 @@ jobs: build: runs-on: ubuntu-latest strategy: + fail-fast: false matrix: go: [1.11, 1.12, 1.13, 1.14, 1.15, 1.16] steps: From 82fc58ca83792f2c97c2a8a85206152765514f28 Mon Sep 17 00:00:00 2001 From: "Banse, Christian" Date: Fri, 28 May 2021 11:21:50 +0200 Subject: [PATCH 8/8] Only testing legacy versions on travis. Will be deprecated in time --- .travis.yml | 6 ------ 1 file changed, 6 deletions(-) diff --git a/.travis.yml b/.travis.yml index 3ac7240d..52043f7e 100644 --- a/.travis.yml +++ b/.travis.yml @@ -9,10 +9,4 @@ go: - 1.8 - 1.9 - 1.10 - - 1.11 - - 1.12 - - 1.13 - - 1.14 - - 1.15 - - 1.16 - tip