Skip to content

Fix #3743: Fix SHA and compare regex on route file [Critical] #3848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 15 commits into from
Closed

Fix #3743: Fix SHA and compare regex on route file [Critical] #3848

wants to merge 15 commits into from

Conversation

thibaultmeyer
Copy link
Contributor

@thibaultmeyer thibaultmeyer commented Nov 3, 2016

Related to the issue #3743, this pull request fix the regex used on the route file for SHA and branches comparisons.

  • A SHA hash can only contains a b c d e f 0 1 2 3 4 5 6 7 8 9
  • A branch name could be smaller than 7 characters

tboerger and others added 2 commits November 3, 2016 12:50
@codecov-io
Copy link

codecov-io commented Nov 3, 2016

Current coverage is 1.28% (diff: 0.00%)

No coverage report found for develop at 6bcff78.

Powered by Codecov. Last update 6bcff78...1adde07

@thibaultmeyer thibaultmeyer deleted the fix/3743-route-regexp-branchname branch November 3, 2016 22:05
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants