-
Notifications
You must be signed in to change notification settings - Fork 5k
Add config option for HTML render mode #3608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Oh, this is a security vulnerability and you may have reported it privately to @unknwon. However once it is public now it should be fixed as fast as possible. |
I would like this option to remain because I depend on it, but it should be off by default for security reasons. |
Have a look at go-gitea/gitea#685 . I have added an option which moves this into the config file. |
Added '[repository] ENABLE_RAW_FILE_RENDER_MODE'.
Patch has pushed to fix this issue, please test on This is disabled by default, see details b3c4a39. |
As in #2593 , you add a
?render=1
which could render html file instead of raw mode.This may lead to a security problem.
render
param, like: https://try.gogs.io/kookxiang/demo/raw/master/index.htm?render=1Just like Github, an html cannot be render under github.com domain.
So they use a github.io domain to keep main domain secure.
Please remove this param, or at least move the option into config file.
The text was updated successfully, but these errors were encountered: