Continuous Integration Overhaul #783

Bromeon · 2021-09-14T20:20:54Z

CI improvements:

Run time optimization (16min -> 6-11min)
- Job-local cache of Rust, LLVM, Godot
- Avoid unnecessary steps (e.g. cargo check instead of build, download LLVM only on Windows)
- Parallelize independent steps into jobs (e.g. test and check-release)
- Disable incremental compilation
Code ergonomics
- Consistent use of external actions and their versions
- Own composite actions for Rust and LLVM
- Comments and explanations
New workflow Minimal CI
- Runs automatically on PRs
- Basic checks, unit tests and Godot integration tests on Linux
- Very fast feedback (typically 2.5 - 4min)
Existing workflow Full CI
- Fix nightly jobs not actually using nightly toolchain
- Updated versions of external actions
- Minor restructuring/grouping
- Option to fast-fail on job and workflow level
- Run tests against MSRV (excluding UI tests with expected compiler errors)
- Naming of jobs/steps, colorized Cargo output

Bromeon · 2021-09-14T21:10:20Z

bors try

bors · 2021-09-14T21:22:12Z

try

Build succeeded:

ci

jacobsky · 2021-09-15T02:25:17Z

@Bromeon The changes look good to me. It looks like the checks have come back as successful. There's quite a few commits, so it might be worth squashing them though :)

Bromeon · 2021-09-15T09:49:47Z

bors try

Bromeon · 2021-09-15T14:24:02Z

Why didn't bors report failure? Let's try again (test-ios is currently broken)

bors try

bors · 2021-09-15T14:24:03Z

try

Already running a review

jacobsky

Looks good to me. It looks like the runs passed as well. Great job!

Squash the commits and let's merge it :)

(You can also not if you want to see your total contributions jump up by 70 :P

Bromeon · 2021-09-15T14:30:05Z

Haha, I'll definitely squash this messy history ;)

bors try-

Bromeon · 2021-09-15T14:31:36Z

bors try

bors · 2021-09-15T19:27:31Z

try

Build succeeded:

full-ci

Bromeon · 2021-09-15T19:36:35Z

bors r+

783: Continuous Integration Overhaul r=Bromeon a=Bromeon CI improvements: * Run time optimization (16min -> 6-11min) * Job-local cache of Rust, LLVM, Godot * Avoid unnecessary steps (e.g. cargo check instead of build, download LLVM only on Windows) * Parallelize independent steps into jobs (e.g. test and check-release) * Disable incremental compilation * Code ergonomics * Consistent use of external actions and their versions * Own composite actions for Rust and LLVM * Comments and explanations * New workflow `Minimal CI` * Runs automatically on PRs * Basic checks, unit tests and Godot integration tests on Linux * Very fast feedback (typically 2.5 - 4min) * Existing workflow `Full CI` * Updated versions of external actions * Minor restructuring/grouping * Option to fast-fail on job and workflow level * Run tests against MSRV (excluding UI tests with expected compiler errors) * Naming of jobs/steps, colorized Cargo output Co-authored-by: Jan Haller <[email protected]>

bors · 2021-09-15T19:37:33Z

Canceled.

Bromeon · 2021-09-15T19:38:11Z

bors r+

783: Continuous Integration Overhaul r=Bromeon a=Bromeon CI improvements: * Run time optimization (16min -> 6-11min) * Job-local cache of Rust, LLVM, Godot * Avoid unnecessary steps (e.g. cargo check instead of build, download LLVM only on Windows) * Parallelize independent steps into jobs (e.g. test and check-release) * Disable incremental compilation * Code ergonomics * Consistent use of external actions and their versions * Own composite actions for Rust and LLVM * Comments and explanations * New workflow `Minimal CI` * Runs automatically on PRs * Basic checks, unit tests and Godot integration tests on Linux * Very fast feedback (typically 2.5 - 4min) * Existing workflow `Full CI` * Fix nightly jobs not actually using nightly toolchain * Updated versions of external actions * Minor restructuring/grouping * Option to fast-fail on job and workflow level * Run tests against MSRV (excluding UI tests with expected compiler errors) * Naming of jobs/steps, colorized Cargo output Co-authored-by: Jan Haller <[email protected]>

bors · 2021-09-15T19:47:18Z

Build failed:

full-ci

Bromeon · 2021-09-15T19:55:57Z

(canceled -- I thought I can fix the nightly tests, but actually UI tests differ, meaning there's no point)
bors r+

783: Continuous Integration Overhaul r=Bromeon a=Bromeon CI improvements: * Run time optimization (16min -> 6-11min) * Job-local cache of Rust, LLVM, Godot * Avoid unnecessary steps (e.g. cargo check instead of build, download LLVM only on Windows) * Parallelize independent steps into jobs (e.g. test and check-release) * Disable incremental compilation * Code ergonomics * Consistent use of external actions and their versions * Own composite actions for Rust and LLVM * Comments and explanations * New workflow `Minimal CI` * Runs automatically on PRs * Basic checks, unit tests and Godot integration tests on Linux * Very fast feedback (typically 2.5 - 4min) * Existing workflow `Full CI` * Fix nightly jobs not actually using nightly toolchain * Updated versions of external actions * Minor restructuring/grouping * Option to fast-fail on job and workflow level * Run tests against MSRV (excluding UI tests with expected compiler errors) * Naming of jobs/steps, colorized Cargo output Co-authored-by: Jan Haller <[email protected]>

bors · 2021-09-15T20:00:24Z

Canceled.

Bromeon · 2021-09-15T20:34:16Z

bors try

bors · 2021-09-15T20:43:19Z

try

Build succeeded:

full-ci

* Run time optimization (16min -> 6-11min) * Job-local cache of Rust, LLVM, Godot * Avoid unnecessary steps (e.g. cargo check instead of build, download LLVM only on Windows) * Parallelize independent steps into jobs (e.g. test and check-release) * Disable incremental compilation * Code ergonomics * Consistent use of external actions and their versions * Own composite actions for Rust and LLVM * Comments and explanations * New workflow `Minimal CI` * Runs automatically on PRs * Basic checks, unit tests and Godot integration tests on Linux * Very fast feedback (typically 2.5 - 4min) * Existing workflow `Full CI` * Fix nightly jobs not actually using nightly toolchain * Updated versions of external actions * Minor restructuring/grouping * Option to fast-fail on job and workflow level * Run tests against MSRV (excluding UI tests with expected compiler errors) * Naming of jobs/steps, colorized Cargo output

Bromeon · 2021-09-15T20:52:14Z

bors r+

bors · 2021-09-15T21:03:41Z

Build succeeded:

full-ci

Bromeon changed the title ~~Feature/ci build time~~ CI overhaul Sep 14, 2021

Bromeon added feature Adds functionality to the library c: tools Component: tooling, tests, IDEs, Cargo, Rust ecosystem labels Sep 14, 2021

bors bot added a commit that referenced this pull request Sep 14, 2021

Try #783:

8c937a2

Bromeon force-pushed the feature/ci-build-time branch 9 times, most recently from 6e13119 to 8497f14 Compare September 14, 2021 23:03

Bromeon force-pushed the feature/ci-build-time branch 7 times, most recently from 6c7c249 to 2b68389 Compare September 15, 2021 09:15

bors bot added a commit that referenced this pull request Sep 15, 2021

Try #783:

f12a2eb

jacobsky previously approved these changes Sep 15, 2021

View reviewed changes

Bromeon force-pushed the feature/ci-build-time branch from 2e6eba3 to 1d1280f Compare September 15, 2021 18:59

bors bot added a commit that referenced this pull request Sep 15, 2021

Try #783:

d5a48b5

Bromeon force-pushed the feature/ci-build-time branch 2 times, most recently from 6c9b6be to c185b10 Compare September 15, 2021 19:36

Bromeon force-pushed the feature/ci-build-time branch from c185b10 to f755f97 Compare September 15, 2021 19:37

Bromeon force-pushed the feature/ci-build-time branch from f755f97 to 548aded Compare September 15, 2021 20:00

Bromeon force-pushed the feature/ci-build-time branch 2 times, most recently from ba8471f to 3a48b34 Compare September 15, 2021 20:33

bors bot added a commit that referenced this pull request Sep 15, 2021

Try #783:

4dfa5fc

Bromeon added 2 commits September 15, 2021 22:50

Comment out unused Api::name (fixes warning in nightly)

bf41471

Bromeon force-pushed the feature/ci-build-time branch from 3a48b34 to bf41471 Compare September 15, 2021 20:51

bors bot merged commit 3ddb6e6 into godot-rust:master Sep 15, 2021

Bromeon deleted the feature/ci-build-time branch September 15, 2021 21:06

Bromeon added c: ci Component: CI and automation and removed c: tools Component: tooling, tests, IDEs, Cargo, Rust ecosystem labels Oct 14, 2021

Continuous Integration Overhaul #783

Continuous Integration Overhaul #783

Uh oh!

Conversation

Bromeon commented Sep 14, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Bromeon commented Sep 14, 2021

Uh oh!

bors bot commented Sep 14, 2021

try

Uh oh!

jacobsky commented Sep 15, 2021

Uh oh!

Bromeon commented Sep 15, 2021

Uh oh!

Bromeon commented Sep 15, 2021

Uh oh!

bors bot commented Sep 15, 2021

try

Uh oh!

jacobsky left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Bromeon commented Sep 15, 2021

Uh oh!

Bromeon commented Sep 15, 2021

Uh oh!

bors bot commented Sep 15, 2021

try

Uh oh!

Bromeon commented Sep 15, 2021

Uh oh!

bors bot commented Sep 15, 2021

Uh oh!

Bromeon commented Sep 15, 2021

Uh oh!

bors bot commented Sep 15, 2021

Uh oh!

Bromeon commented Sep 15, 2021

Uh oh!

bors bot commented Sep 15, 2021

Uh oh!

Bromeon commented Sep 15, 2021

Uh oh!

bors bot commented Sep 15, 2021

try

Uh oh!

Bromeon commented Sep 15, 2021

Uh oh!

bors bot commented Sep 15, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Bromeon commented Sep 14, 2021 •

edited

Loading

jacobsky left a comment •

edited

Loading