Ctrl+C and SIGTERM does nothing when --watch flag is used

[rmmcnulty9]

Hello, I am trying to use the --watch for one of my tasks but I can not stop task when I am done. I have to kill -9 task. Am I missing something?

[andreynering]

Hi @rmmcnulty9, thanks for reporting this bug!

I plan to take a look at it soon

[andreynering]

@rmmcnulty9 Can you tell me what operating system you're using?

[grzegorz-zur]

You need to range over signals in this function

task/cmd/task/task.go

Line 140 in 687b4ec

go func() {

I can send pull request later.

[grzegorz-zur]

There is also no call to context.Done method anywhere in the code.

[andreynering]

@grzegorz-zur Done os called on the sh lib. See:

https://github.com/mvdan/sh/blob/3a244a89e2e520d2777e94693d51bef800761879/interp/module.go#L81

Let me know if you need help

[rmmcnulty9]

Hello @andreynering , sorry for the slow reply. I am using Ubuntu 18.04
HTH

[grzegorz-zur]

@andreynering It seems that in the file watch.go new contexts are created. The context used in signal handler is not the one used in watch mode.

[andreynering]

@rmmcnulty9 @grzegorz-zur Thanks, I was able to identify the problem: there was no break or return inside the infinite loop, so even if the context was cancelled, the program would not exit.

I fixed it by having a different signal handling to explicitly close the watcher.

[andreynering]

Let me know if you still experience problems after this fix.

[andreynering]

v2.1.1 is released with this fix

[rmmcnulty9]

Thanks for the quick turn around. I am very anxious to drop make for task 😄