revert NewConfig incompatible change

methane · methane · commit 5f2654f07eab · 2024-02-26T18:50:48.000+09:00
diff --git a/dsn.go b/dsn.go
@@ -80,7 +80,7 @@ type Config struct {
 type option func(*Config) error
 
 // NewConfig creates a new Config and sets default values.
-func NewConfig(opts ...option) *Config {
+func NewConfig() *Config {
 	cfg := &Config{
 		Loc:                  time.UTC,
 		MaxAllowedPacket:     defaultMaxAllowedPacket,
@@ -89,7 +89,6 @@ func NewConfig(opts ...option) *Config {
 		CheckConnLiveness:    true,
 	}
 
-	cfg.SetOptions(opts...)
 	return cfg
 }
 

Original file line number	Diff line number	Diff line change
`@@ -80,7 +80,7 @@ type Config struct {`
`80`	`80`	`type option func(*Config) error`
`81`	`81`
`82`	`82`	`// NewConfig creates a new Config and sets default values.`
`83`		`-func NewConfig(opts ...option) *Config {`
	`83`	`+func NewConfig() *Config {`
`84`	`84`	`cfg := &Config{`
`85`	`85`	`Loc: time.UTC,`
`86`	`86`	`MaxAllowedPacket: defaultMaxAllowedPacket,`
`@@ -89,7 +89,6 @@ func NewConfig(opts ...option) *Config {`
`89`	`89`	`CheckConnLiveness: true,`
`90`	`90`	`}`
`91`	`91`
`92`		`- cfg.SetOptions(opts...)`
`93`	`92`	`return cfg`
`94`	`93`	`}`
`95`	`94`