Skip to content

v1: Tests failures w/ Go 1.14 beta1 #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
eclipseo opened this issue Feb 7, 2020 · 1 comment
Closed

v1: Tests failures w/ Go 1.14 beta1 #308

eclipseo opened this issue Feb 7, 2020 · 1 comment
Labels
v1 For resty v1

Comments

@eclipseo
Copy link

eclipseo commented Feb 7, 2020

I don't know if you're still maintaining v1 but if it's the case, there are test errors due to a change in Go 1.14 beta 1:


Testing    in: /builddir/build/BUILD/resty-1.12.0/_build/src
         PATH: /builddir/build/BUILD/resty-1.12.0/_build/bin:/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/sbin
       GOPATH: /builddir/build/BUILD/resty-1.12.0/_build:/usr/share/gocode
  GO111MODULE: off
      command: go test -buildmode pie -compiler gc -ldflags "-X gopkg.in/resty.v1/version=1.12.0 -extldflags '-Wl,-z,relro -Wl,--as-needed  -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld '"
      testing: gopkg.in/resty.v1
gopkg.in/resty.v1
--- FAIL: TestClientRedirectPolicy (0.00s)
    resty_test.go:511: Method: GET
    resty_test.go:512: Path: /redirect-1
    resty_test.go:511: Method: GET
    resty_test.go:512: Path: /redirect-2
    resty_test.go:511: Method: GET
    resty_test.go:512: Path: /redirect-3
    resty_test.go:511: Method: GET
    resty_test.go:512: Path: /redirect-4
    resty_test.go:511: Method: GET
    resty_test.go:512: Path: /redirect-5
    resty_test.go:511: Method: GET
    resty_test.go:512: Path: /redirect-6
    resty_test.go:511: Method: GET
    resty_test.go:512: Path: /redirect-7
    resty_test.go:511: Method: GET
    resty_test.go:512: Path: /redirect-8
    resty_test.go:511: Method: GET
    resty_test.go:512: Path: /redirect-9
    resty_test.go:511: Method: GET
    resty_test.go:512: Path: /redirect-10
    resty_test.go:511: Method: GET
    resty_test.go:512: Path: /redirect-11
    resty_test.go:511: Method: GET
    resty_test.go:512: Path: /redirect-12
    resty_test.go:511: Method: GET
    resty_test.go:512: Path: /redirect-13
    resty_test.go:511: Method: GET
    resty_test.go:512: Path: /redirect-14
    resty_test.go:511: Method: GET
    resty_test.go:512: Path: /redirect-15
    resty_test.go:511: Method: GET
    resty_test.go:512: Path: /redirect-16
    resty_test.go:511: Method: GET
    resty_test.go:512: Path: /redirect-17
    resty_test.go:511: Method: GET
    resty_test.go:512: Path: /redirect-18
    resty_test.go:511: Method: GET
    resty_test.go:512: Path: /redirect-19
    resty_test.go:511: Method: GET
    resty_test.go:512: Path: /redirect-20
    resty_test.go:586: Expected [Get /redirect-21: stopped after 20 redirects], got [Get "/redirect-21": stopped after 20 redirects]
--- FAIL: TestClientRetryWithSetContext (4.23s)
    context_test.go:179: Method: GET
    context_test.go:180: Path: /
    context_test.go:179: Method: GET
    context_test.go:180: Path: /
    context_test.go:179: Method: GET
    context_test.go:180: Path: /
    resty_test.go:586: Expected [true], got [false]
--- FAIL: TestNoAutoRedirect (0.00s)
    resty_test.go:511: Method: GET
    resty_test.go:512: Path: /redirect-1
    resty_test.go:586: Expected [Get /redirect-2: auto redirect is disabled], got [Get "/redirect-2": auto redirect is disabled]
--- FAIL: TestHTTPAutoRedirectUpTo10 (0.00s)
    resty_test.go:511: Method: GET
    resty_test.go:512: Path: /redirect-1
    resty_test.go:511: Method: GET
    resty_test.go:512: Path: /redirect-2
    resty_test.go:511: Method: GET
    resty_test.go:512: Path: /redirect-3
    resty_test.go:511: Method: GET
    resty_test.go:512: Path: /redirect-4
    resty_test.go:511: Method: GET
    resty_test.go:512: Path: /redirect-5
    resty_test.go:511: Method: GET
    resty_test.go:512: Path: /redirect-6
    resty_test.go:511: Method: GET
    resty_test.go:512: Path: /redirect-7
    resty_test.go:511: Method: GET
    resty_test.go:512: Path: /redirect-8
    resty_test.go:511: Method: GET
    resty_test.go:512: Path: /redirect-9
    resty_test.go:511: Method: GET
    resty_test.go:512: Path: /redirect-10
    resty_test.go:586: Expected [Get /redirect-11: stopped after 10 redirects], got [Get "/redirect-11": stopped after 10 redirects]
--- FAIL: TestIncorrectURL (0.00s)
    resty_test.go:586: Expected [true], got [false]
    resty_test.go:586: Expected [true], got [false]
--- FAIL: TestClientRetryGet (12.24s)
    resty_test.go:41: Method: GET
    resty_test.go:42: Path: /set-retrycount-test
    resty_test.go:41: Method: GET
    resty_test.go:42: Path: /set-retrycount-test
    resty_test.go:41: Method: GET
    resty_test.go:42: Path: /set-retrycount-test
    resty_test.go:586: Expected [true], got [false]
FAIL
exit status 1
FAIL	gopkg.in/resty.v1	58.845s

See golang/go@64cfe9f
and
golang/go#29261 for the changes to Error reporting.

@jeevatkm
Copy link
Member

jeevatkm commented Feb 9, 2020

@eclipseo Thanks and I appreciate your issue reporting. Resty v1 support got completed last year, currently, it's not maintained.

@jeevatkm jeevatkm closed this as completed Feb 9, 2020
@jeevatkm jeevatkm added the v1 For resty v1 label Feb 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v1 For resty v1
Development

No branches or pull requests

2 participants