Skip to content

Examples missing #1657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
oluwandabira opened this issue Jul 10, 2020 · 3 comments
Closed

Examples missing #1657

oluwandabira opened this issue Jul 10, 2020 · 3 comments

Comments

@oluwandabira
Copy link

The readme links some examples which don't exist on the doc page. For instance the ForEach link goes to https://pkg.go.dev/github.com/go-pg/pg/v10?tab=doc#example-DB-Model-ForEach where there is no ForEach example.

The doc page only has examples for Array, Connect, DB (ArrayValueScanner), DB (DiscardUnknownColumns), DB (JsonUseNumber), DB.WithTimeout, Error, Hstore, Ints, Listener, Scan and, Strings. The readme links invalid examples such for Transactions, PreparedStatements, Copying, Working with the ORM and SQL and so on (so basically, most examples).

@vmihailenco
Copy link
Member

This is a problem with pkg.go.dev. godoc.org displays example properly - https://godoc.org/github.com/go-pg/pg?tab=doc#example-DB-Model-ForEach

@oluwandabira
Copy link
Author

So should I close this?

@vmihailenco
Copy link
Member

I've created golang/go#40172 - let's see what is the feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants