From c7b6c988caf78ef476e9ababfdec37a9bd55e93f Mon Sep 17 00:00:00 2001 From: 6543 <6543@obermui.de> Date: Mon, 28 Oct 2019 23:54:32 +0100 Subject: [PATCH 1/2] BugFix: Update closed_date_unix colum on milestone table on close --- models/issue_milestone.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/models/issue_milestone.go b/models/issue_milestone.go index d32cb3c7d1f4a..14bebbf834732 100644 --- a/models/issue_milestone.go +++ b/models/issue_milestone.go @@ -306,7 +306,9 @@ func ChangeMilestoneStatus(m *Milestone, isClosed bool) (err error) { } m.IsClosed = isClosed - if _, err := sess.ID(m.ID).Cols("is_closed").Update(m); err != nil { + if isClosed { m.ClosedDateUnix = timeutil.TimeStampNow() } + + if _, err := sess.ID(m.ID).Cols("is_closed","closed_date_unix").Update(m); err != nil { return err } From e901e0a4834d0ca8ad4a75d86e6977e98fdab7d1 Mon Sep 17 00:00:00 2001 From: 6543 <6543@obermui.de> Date: Mon, 28 Oct 2019 23:55:25 +0100 Subject: [PATCH 2/2] go fmt --- models/issue_milestone.go | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/models/issue_milestone.go b/models/issue_milestone.go index 14bebbf834732..a4c2b4b0622c7 100644 --- a/models/issue_milestone.go +++ b/models/issue_milestone.go @@ -306,9 +306,11 @@ func ChangeMilestoneStatus(m *Milestone, isClosed bool) (err error) { } m.IsClosed = isClosed - if isClosed { m.ClosedDateUnix = timeutil.TimeStampNow() } + if isClosed { + m.ClosedDateUnix = timeutil.TimeStampNow() + } - if _, err := sess.ID(m.ID).Cols("is_closed","closed_date_unix").Update(m); err != nil { + if _, err := sess.ID(m.ID).Cols("is_closed", "closed_date_unix").Update(m); err != nil { return err }