Skip to content

Change reserved avatar name to correct "avatars" #3375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lafriks merged 2 commits into from
Jan 15, 2018
Merged

Change reserved avatar name to correct "avatars" #3375

lafriks merged 2 commits into from
Jan 15, 2018

Conversation

@lafriks
Copy link
Member

@lafriks lafriks commented Jan 15, 2018

Fixes #3374

@lafriks lafriks added this to the 1.4.0 milestone Jan 15, 2018
@thehowl
Copy link
Contributor

thehowl commented Jan 15, 2018

LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 15, 2018
@codecov-io
Copy link

codecov-io commented Jan 15, 2018 •
edited
Loading

Codecov Report

Merging #3375 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3375   +/-   ##
=======================================
  Coverage   35.01%   35.01%           
=======================================
  Files         281      281           
  Lines       40560    40560           
=======================================
  Hits        14204    14204           
  Misses      24255    24255           
  Partials     2101     2101
Impacted Files Coverage Δ
models/user.go 39.75% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2bb793...57d6080. Read the comment docs.

@strk
Copy link
Member

strk commented Jan 15, 2018

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 15, 2018
@lafriks lafriks merged commit a68bf74 into go-gitea:master Jan 15, 2018
@lafriks lafriks deleted the fix/reserved_avatars branch January 15, 2018 22:45
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@sapk sapk sapk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Milestone

1.4.0

Development

Successfully merging this pull request may close these issues.

avatars is allowed as an username

6 participants

@lafriks @thehowl @codecov-io @strk @sapk @tboerger