refactor(model): update user method.

[appleboy]

as title.

[codecov-io]

Codecov Report

Merging #3360 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #3360      +/-   ##
==========================================
- Coverage   35.05%   35.03%   -0.02%     
==========================================
  Files         281      281              
  Lines       40559    40543      -16     
==========================================
- Hits        14219    14206      -13     
+ Misses      24236    24234       -2     
+ Partials     2104     2103       -1

Impacted Files	Coverage Δ
models/user.go	39.75% <100%> (-0.4%)	⬇️
modules/process/manager.go	76.81% <0%> (-4.35%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f708829...4dab3b6. Read the comment docs.

[thehowl]

LGTM

[lafriks]

Is this PR really does not change behaviour?

[thehowl]

I'm quite sure it should not: this is the update code on xorm, so it is always run. Are you perhaps referring to the code running in cases where it wouldn't have before? (e.g. user_mail.go#L225)

[appleboy]

@lafriks No, just like @thehowl say.We always get user data from x.Get(user) before execute the Update(user) method.

[lunny]

LGTM