Skip to content

Conversation

@ethantkoenig
Copy link
Member

@ethantkoenig ethantkoenig commented Dec 22, 2017

Includes go-gitea/git#101, which is a fix for #3242

@codecov-io
Copy link

Codecov Report

Merging #3251 into master will increase coverage by 0.18%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3251      +/-   ##
==========================================
+ Coverage    34.7%   34.88%   +0.18%     
==========================================
  Files         277      277              
  Lines       40108    40108              
==========================================
+ Hits        13918    13993      +75     
+ Misses      24157    24064      -93     
- Partials     2033     2051      +18
Impacted Files Coverage Δ
modules/process/manager.go 76.81% <0%> (-4.35%) ⬇️
models/lfs.go 28.26% <0%> (+2.17%) ⬆️
modules/lfs/server.go 35.01% <0%> (+14.32%) ⬆️
modules/lfs/content_store.go 43.75% <0%> (+35.93%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 515cdaa...7820601. Read the comment docs.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 22, 2017
@lafriks lafriks added this to the 1.4.0 milestone Dec 22, 2017
@lafriks
Copy link
Member

lafriks commented Dec 22, 2017

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 22, 2017
@lunny
Copy link
Member

lunny commented Dec 22, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 22, 2017
@lafriks lafriks merged commit 156aa42 into go-gitea:master Dec 22, 2017
@ethantkoenig ethantkoenig deleted the update/vendor branch January 13, 2018 20:37
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants