From 6217f3cd64934bd013e3440871ff959ea4dac08f Mon Sep 17 00:00:00 2001 From: lng2020 Date: Sat, 21 Oct 2023 18:43:45 +0800 Subject: [PATCH 1/3] fix issue not showing no default board --- models/issues/issue_search.go | 2 +- modules/indexer/issues/indexer_test.go | 6 ++++++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/models/issues/issue_search.go b/models/issues/issue_search.go index 9b6bf117b1f84..0bea1fed143b0 100644 --- a/models/issues/issue_search.go +++ b/models/issues/issue_search.go @@ -186,7 +186,7 @@ func applyProjectBoardCondition(sess *xorm.Session, opts *IssuesOptions) *xorm.S if opts.ProjectBoardID > 0 { sess.In("issue.id", builder.Select("issue_id").From("project_issue").Where(builder.Eq{"project_board_id": opts.ProjectBoardID})) } else if opts.ProjectBoardID == db.NoConditionID { - sess.In("issue.id", builder.Select("issue_id").From("project_issue").Where(builder.Neq{"project_board_id": 0})) + sess.In("issue.id", builder.Select("issue_id").From("project_issue").Where(builder.Eq{"project_board_id": 0})) } return sess } diff --git a/modules/indexer/issues/indexer_test.go b/modules/indexer/issues/indexer_test.go index 0ec23164c2808..2b9cbde5fffe0 100644 --- a/modules/indexer/issues/indexer_test.go +++ b/modules/indexer/issues/indexer_test.go @@ -382,6 +382,12 @@ func searchIssueInProject(t *testing.T) { }, []int64{1}, }, + { + SearchOptions{ + ProjectBoardID: int64Pointer(db.NoConditionID), // issue with in default board + }, + []int64{2}, + }, } for _, test := range tests { issueIDs, _, err := SearchIssues(context.TODO(), &test.opts) From 2849ecae6ab73c08f812a546626bed005e10a823 Mon Sep 17 00:00:00 2001 From: Nanguan Lin <70063547+lng2020@users.noreply.github.com> Date: Sat, 21 Oct 2023 18:48:39 +0800 Subject: [PATCH 2/3] Update indexer_test.go --- modules/indexer/issues/indexer_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/indexer/issues/indexer_test.go b/modules/indexer/issues/indexer_test.go index 2b9cbde5fffe0..3a80ea434e35a 100644 --- a/modules/indexer/issues/indexer_test.go +++ b/modules/indexer/issues/indexer_test.go @@ -384,7 +384,7 @@ func searchIssueInProject(t *testing.T) { }, { SearchOptions{ - ProjectBoardID: int64Pointer(db.NoConditionID), // issue with in default board + ProjectBoardID: 0, // issue with in default board }, []int64{2}, }, From f9973358e57ee0bccd467212b2b6e9194f6f79a3 Mon Sep 17 00:00:00 2001 From: Nanguan Lin <70063547+lng2020@users.noreply.github.com> Date: Sat, 21 Oct 2023 18:55:55 +0800 Subject: [PATCH 3/3] Update indexer_test.go --- modules/indexer/issues/indexer_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/indexer/issues/indexer_test.go b/modules/indexer/issues/indexer_test.go index 3a80ea434e35a..da4fc9b878999 100644 --- a/modules/indexer/issues/indexer_test.go +++ b/modules/indexer/issues/indexer_test.go @@ -384,7 +384,7 @@ func searchIssueInProject(t *testing.T) { }, { SearchOptions{ - ProjectBoardID: 0, // issue with in default board + ProjectBoardID: int64Pointer(0), // issue with in default board }, []int64{2}, },