From c6a93597669f17c36abe543bf41462408ac2fb98 Mon Sep 17 00:00:00 2001
From: silverwind <me@silverwind.io>
Date: Sun, 18 Jun 2023 13:52:23 +0200
Subject: [PATCH 1/9] Navbar styling rework

---
 templates/base/head_navbar.tmpl |  12 ++--
 web_src/css/base.css            |  96 -------------------------
 web_src/css/index.css           |   1 +
 web_src/css/modules/navbar.css  | 120 ++++++++++++++++++++++++++++++++
 4 files changed, 127 insertions(+), 102 deletions(-)
 create mode 100644 web_src/css/modules/navbar.css

diff --git a/templates/base/head_navbar.tmpl b/templates/base/head_navbar.tmpl
index e46e276ed02e3..9c795719b3c10 100644
--- a/templates/base/head_navbar.tmpl
+++ b/templates/base/head_navbar.tmpl
@@ -4,9 +4,9 @@
 {{end}}
 
 <nav id="navbar" class="ui secondary stackable menu" aria-label="{{.locale.Tr "aria.navbar"}}">
-	<div class="item">
+	<div class="navbar-left">
 		<!-- the logo -->
-		<a href="{{AppSubUrl}}/" aria-label="{{if .IsSigned}}{{.locale.Tr "dashboard"}}{{else}}{{.locale.Tr "home"}}{{end}}">
+		<a class="item" id="navbar-logo" href="{{AppSubUrl}}/" aria-label="{{if .IsSigned}}{{.locale.Tr "dashboard"}}{{else}}{{.locale.Tr "home"}}{{end}}">
 			<img width="30" height="30" src="{{AssetUrlPrefix}}/img/logo.svg" alt="{{.locale.Tr "logo"}}" aria-hidden="true">
 		</a>
 
@@ -53,12 +53,12 @@
 	{{end}}
 
 	<!-- the full dropdown menus -->
-	<div class="right menu">
+	<div class="navbar-right">
 		{{if and .IsSigned .MustChangePassword}}
 			<div class="ui dropdown jump item" data-tooltip-content="{{.locale.Tr "user_profile_and_more"}}">
 				<span class="text gt-df gt-ac">
 					{{avatar $.Context .SignedUser 24 "gt-mr-2"}}
-					<span class="mobile-only gt-ml-2">{{.SignedUser.Name}}</span>
+					<span class="mobile-only gt-ml-3">{{.SignedUser.Name}}</span>
 					<span class="not-mobile">{{svg "octicon-triangle-down"}}</span>
 				</span>
 				<div class="menu user-menu">
@@ -80,7 +80,7 @@
 					{{svg "octicon-stopwatch"}}
 					<span class="header-stopwatch-dot"></span>
 				</div>
-				<span class="mobile-only gt-ml-2">{{.locale.Tr "active_stopwatch"}}</span>
+				<span class="mobile-only gt-ml-3">{{.locale.Tr "active_stopwatch"}}</span>
 			</a>
 			<div class="active-stopwatch-popup tippy-target gt-p-3">
 				<div class="gt-df gt-ac">
@@ -144,7 +144,7 @@
 			<div class="ui dropdown jump item gt-mx-0 gt-pr-3" data-tooltip-content="{{.locale.Tr "user_profile_and_more"}}">
 				<span class="text gt-df gt-ac">
 					{{avatar $.Context .SignedUser 24 "gt-mr-2"}}
-					<span class="mobile-only gt-ml-2">{{.SignedUser.Name}}</span>
+					<span class="mobile-only gt-ml-3">{{.SignedUser.Name}}</span>
 					<span class="not-mobile">{{svg "octicon-triangle-down"}}</span>
 				</span>
 				<div class="menu user-menu">
diff --git a/web_src/css/base.css b/web_src/css/base.css
index a876885632abc..7322b778f3625 100644
--- a/web_src/css/base.css
+++ b/web_src/css/base.css
@@ -930,102 +930,6 @@ img.ui.avatar,
   }
 }
 
-#navbar {
-  display: flex;
-  align-items: center;
-  background: var(--color-nav-bg);
-  border-bottom: 1px solid var(--color-secondary);
-  min-height: 52px;
-  margin: 0 !important;
-}
-
-#navbar a.item:hover {
-  background: var(--color-nav-hover-bg);
-}
-
-#navbar .navbar-mobile-right {
-  margin-left: auto;
-}
-
-#navbar .navbar-mobile-right a.item:hover {
-  background: transparent;
-}
-
-#navbar .secondary.menu > .item > .svg,
-#navbar .right.menu > .item > .svg {
-  margin-right: 0;
-}
-
-@media (max-width: 767.98px) {
-  /* hide all items */
-  #navbar .item {
-    display: none;
-  }
-  /* show the first navbar item (logo and its mobile right items) */
-  #navbar > .item:first-child {
-    display: flex;
-    padding-top: 5px;
-    padding-bottom: 5px;
-  }
-  #navbar .navbar-mobile-right > .item {
-    display: flex;
-  }
-  /* show items if the navbar is open */
-  #navbar.navbar-menu-open .item {
-    display: flex;
-  }
-  #navbar.navbar-menu-open > .item:first-child {
-    padding-bottom: 0;
-  }
-}
-
-@media (min-width: 767.98px) {
-  #navbar .navbar-mobile-right,
-  #navbar .mobile-only {
-    display: none;
-  }
-  #navbar .right.menu {
-    padding-right: 1em;
-  }
-}
-
-#navbar .navbar-mobile-right .item {
-  width: auto !important;
-}
-
-#navbar a.item .notification_count {
-  color: var(--color-nav-bg);
-  padding: 0 3.75px;
-  font-size: 12px;
-  line-height: 12px;
-  font-weight: var(--font-weight-bold);
-}
-
-#navbar a.item:hover .notification_count,
-#navbar a.item:hover .header-stopwatch-dot {
-  border-color: var(--color-nav-hover-bg);
-}
-
-#navbar a.item .notification_count,
-#navbar a.item .header-stopwatch-dot {
-  background: var(--color-primary);
-  border: 2px solid var(--color-nav-bg);
-  position: absolute;
-  left: 6px;
-  top: -9px;
-  min-width: 17px;
-  min-height: 17px;
-  border-radius: 17px;
-  display: flex;
-  align-items: center;
-  justify-content: center;
-}
-
-#navbar .right.menu {
-  width: 100%;
-  justify-content: flex-end;
-}
-
 .ui.pagination.menu .active.item {
   color: var(--color-text);
   background: var(--color-active);
diff --git a/web_src/css/index.css b/web_src/css/index.css
index 125249ceab9f5..21ae4c1b1f0d5 100644
--- a/web_src/css/index.css
+++ b/web_src/css/index.css
@@ -7,6 +7,7 @@
 @import "./modules/breadcrumb.css";
 @import "./modules/card.css";
 @import "./modules/comment.css";
+@import "./modules/navbar.css";
 
 @import "./shared/issuelist.css";
 @import "./shared/milestone.css";
diff --git a/web_src/css/modules/navbar.css b/web_src/css/modules/navbar.css
new file mode 100644
index 0000000000000..07d27e50f6036
--- /dev/null
+++ b/web_src/css/modules/navbar.css
@@ -0,0 +1,120 @@
+#navbar {
+  display: flex;
+  align-items: center;
+  background: var(--color-nav-bg);
+  border-bottom: 1px solid var(--color-secondary);
+  margin: 0 !important;
+  padding: 0 10px;
+}
+
+#navbar,
+#navbar .navbar-left {
+  min-height: 48px;
+}
+
+#navbar-logo {
+  margin: 0;
+  width: auto !important;
+}
+
+#navbar .navbar-left {
+  display: flex;
+  align-items: center;
+}
+
+#navbar .navbar-right {
+  width: 100%;
+  display: flex;
+  justify-content: flex-end;
+}
+
+#navbar .item {
+  min-height: 36px;
+  min-width: 36px;
+  padding-top: 3px;
+  padding-bottom: 3px;
+  display: flex;
+  justify-content: center;
+}
+
+#navbar a.item:hover,
+#navbar button.item:hover {
+  background: var(--color-nav-hover-bg);
+}
+
+#navbar .navbar-mobile-right {
+  margin-left: auto;
+}
+
+#navbar .secondary.menu > .item > .svg,
+#navbar .right.menu > .item > .svg {
+  margin-right: 0;
+}
+
+@media (max-width: 767.98px) {
+  #navbar {
+    align-items: stretch;
+    padding-bottom: 8px;
+  }
+  /* hide all items */
+  #navbar .item {
+    display: none;
+  }
+  #navbar #navbar-logo {
+    display: flex;
+  }
+  /* show the first navbar item (logo and its mobile right items) */
+  #navbar .navbar-left {
+    flex: 1;
+    display: flex;
+  }
+  #navbar .navbar-mobile-right > .item {
+    display: flex;
+  }
+  /* show items if the navbar is open */
+  #navbar.navbar-menu-open .item {
+    display: flex;
+  }
+  #navbar .navbar-right {
+    flex-direction: column;
+  }
+}
+
+@media (min-width: 767.98px) {
+  #navbar .navbar-mobile-right,
+  #navbar .mobile-only {
+    display: none;
+  }
+}
+
+#navbar .navbar-mobile-right .item {
+  width: auto !important;
+}
+
+#navbar a.item .notification_count {
+  color: var(--color-nav-bg);
+  padding: 0 3.75px;
+  font-size: 12px;
+  line-height: 12px;
+  font-weight: var(--font-weight-bold);
+}
+
+#navbar a.item:hover .notification_count,
+#navbar a.item:hover .header-stopwatch-dot {
+  border-color: var(--color-nav-hover-bg);
+}
+
+#navbar a.item .notification_count,
+#navbar a.item .header-stopwatch-dot {
+  background: var(--color-primary);
+  border: 2px solid var(--color-nav-bg);
+  position: absolute;
+  left: 6px;
+  top: -9px;
+  min-width: 17px;
+  min-height: 17px;
+  border-radius: 17px;
+  display: flex;
+  align-items: center;
+  justify-content: center;
+}

From b3556e4079f1ae3524806189c4a05d4e80b226af Mon Sep 17 00:00:00 2001
From: silverwind <me@silverwind.io>
Date: Sun, 18 Jun 2023 14:03:30 +0200
Subject: [PATCH 2/9] tweak mobile notification margin

---
 templates/base/head_navbar.tmpl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/templates/base/head_navbar.tmpl b/templates/base/head_navbar.tmpl
index 9c795719b3c10..4ab2dd306b949 100644
--- a/templates/base/head_navbar.tmpl
+++ b/templates/base/head_navbar.tmpl
@@ -13,7 +13,7 @@
 		<!-- mobile right menu, it must be here because in mobile view, each item is a flex column, the first item is a full row column -->
 		<div class="ui secondary menu navbar-mobile-right gt-gap-2">
 			{{if .IsSigned}}
-			<a class="item gt-mx-0 gt-p-3" href="{{AppSubUrl}}/notifications" data-tooltip-content="{{.locale.Tr "notifications"}}" aria-label="{{.locale.Tr "notifications"}}">
+			<a class="item gt-mr-2 gt-p-3" href="{{AppSubUrl}}/notifications" data-tooltip-content="{{.locale.Tr "notifications"}}" aria-label="{{.locale.Tr "notifications"}}">
 				<div class="gt-relative">
 					{{svg "octicon-bell"}}
 					<span class="notification_count{{if not $notificationUnreadCount}} gt-hidden{{end}}">{{$notificationUnreadCount}}</span>

From 9344b6b50387cb15254cd8644ba151a77bd748cb Mon Sep 17 00:00:00 2001
From: silverwind <me@silverwind.io>
Date: Tue, 20 Jun 2023 00:19:40 +0200
Subject: [PATCH 3/9] use suggested html layout and adapt css

---
 templates/base/head_navbar.tmpl | 69 +++++++++++++++++----------------
 web_src/css/modules/navbar.css  | 52 ++++++++++++++++---------
 2 files changed, 68 insertions(+), 53 deletions(-)

diff --git a/templates/base/head_navbar.tmpl b/templates/base/head_navbar.tmpl
index 4ab2dd306b949..23ea1cfa618a9 100644
--- a/templates/base/head_navbar.tmpl
+++ b/templates/base/head_navbar.tmpl
@@ -3,57 +3,58 @@
 	{{$notificationUnreadCount = call .NotificationUnreadCount}}
 {{end}}
 
-<nav id="navbar" class="ui secondary stackable menu" aria-label="{{.locale.Tr "aria.navbar"}}">
-	<div class="navbar-left">
+<nav id="navbar" aria-label="{{.locale.Tr "aria.navbar"}}">
+	<div class="navbar-left ui secondary menu">
 		<!-- the logo -->
 		<a class="item" id="navbar-logo" href="{{AppSubUrl}}/" aria-label="{{if .IsSigned}}{{.locale.Tr "dashboard"}}{{else}}{{.locale.Tr "home"}}{{end}}">
-			<img width="30" height="30" src="{{AssetUrlPrefix}}/img/logo.svg" alt="{{.locale.Tr "logo"}}" aria-hidden="true">
+			<img width="30" height="30" src="{{AssetUrlPrefix}}/img/logo.svg" alt="{{.locale.Tr "logo"}}" aria-hidden="true"/>
 		</a>
 
 		<!-- mobile right menu, it must be here because in mobile view, each item is a flex column, the first item is a full row column -->
-		<div class="ui secondary menu navbar-mobile-right gt-gap-2">
+		<div class="ui secondary menu item navbar-mobile-right gt-gap-2">
 			{{if .IsSigned}}
-			<a class="item gt-mr-2 gt-p-3" href="{{AppSubUrl}}/notifications" data-tooltip-content="{{.locale.Tr "notifications"}}" aria-label="{{.locale.Tr "notifications"}}">
+			<a class="item mobile-right-item mobile-notifications-item gt-mr-2 gt-p-3" href="{{AppSubUrl}}/notifications" data-tooltip-content="{{.locale.Tr "notifications"}}" aria-label="{{.locale.Tr "notifications"}}">
 				<div class="gt-relative">
 					{{svg "octicon-bell"}}
 					<span class="notification_count{{if not $notificationUnreadCount}} gt-hidden{{end}}">{{$notificationUnreadCount}}</span>
 				</div>
 			</a>
 			{{end}}
-			<button class="item ui icon mini button gt-p-3 gt-m-0" id="navbar-expand-toggle">{{svg "octicon-three-bars"}}</button>
+			<button class="item mobile-right-item ui icon mini button gt-p-3 gt-m-0" id="navbar-expand-toggle">{{svg "octicon-three-bars"}}</button>
 		</div>
-	</div>
 
-	<!-- navbar links -->
-	{{if and .IsSigned .MustChangePassword}}
-		{{/* No links */}}
-	{{else if .IsSigned}}
-		{{if not .UnitIssuesGlobalDisabled}}
-			<a class="item{{if .PageIsIssues}} active{{end}}" href="{{AppSubUrl}}/issues">{{.locale.Tr "issues"}}</a>
-		{{end}}
-		{{if not .UnitPullsGlobalDisabled}}
-			<a class="item{{if .PageIsPulls}} active{{end}}" href="{{AppSubUrl}}/pulls">{{.locale.Tr "pull_requests"}}</a>
-		{{end}}
-		{{if not (and .UnitIssuesGlobalDisabled .UnitPullsGlobalDisabled)}}
-			{{if .ShowMilestonesDashboardPage}}
-				<a class="item{{if .PageIsMilestonesDashboard}} active{{end}}" href="{{AppSubUrl}}/milestones">{{.locale.Tr "milestones"}}</a>
+
+		<!-- navbar links non-mobile -->
+		{{if and .IsSigned .MustChangePassword}}
+			{{/* No links */}}
+		{{else if .IsSigned}}
+			{{if not .UnitIssuesGlobalDisabled}}
+				<a class="item{{if .PageIsIssues}} active{{end}}" href="{{AppSubUrl}}/issues">{{.locale.Tr "issues"}}</a>
 			{{end}}
+			{{if not .UnitPullsGlobalDisabled}}
+				<a class="item{{if .PageIsPulls}} active{{end}}" href="{{AppSubUrl}}/pulls">{{.locale.Tr "pull_requests"}}</a>
+			{{end}}
+			{{if not (and .UnitIssuesGlobalDisabled .UnitPullsGlobalDisabled)}}
+				{{if .ShowMilestonesDashboardPage}}
+					<a class="item{{if .PageIsMilestonesDashboard}} active{{end}}" href="{{AppSubUrl}}/milestones">{{.locale.Tr "milestones"}}</a>
+				{{end}}
+			{{end}}
+			<a class="item{{if .PageIsExplore}} active{{end}}" href="{{AppSubUrl}}/explore/repos">{{.locale.Tr "explore"}}</a>
+		{{else if .IsLandingPageOrganizations}}
+			<a class="item{{if .PageIsExplore}} active{{end}}" href="{{AppSubUrl}}/explore/organizations">{{.locale.Tr "explore"}}</a>
+		{{else}}
+			<a class="item{{if .PageIsExplore}} active{{end}}" href="{{AppSubUrl}}/explore/repos">{{.locale.Tr "explore"}}</a>
 		{{end}}
-		<a class="item{{if .PageIsExplore}} active{{end}}" href="{{AppSubUrl}}/explore/repos">{{.locale.Tr "explore"}}</a>
-	{{else if .IsLandingPageOrganizations}}
-		<a class="item{{if .PageIsExplore}} active{{end}}" href="{{AppSubUrl}}/explore/organizations">{{.locale.Tr "explore"}}</a>
-	{{else}}
-		<a class="item{{if .PageIsExplore}} active{{end}}" href="{{AppSubUrl}}/explore/repos">{{.locale.Tr "explore"}}</a>
-	{{end}}
 
-	{{template "custom/extra_links" .}}
+		{{template "custom/extra_links" .}}
 
-	{{if not .IsSigned}}
-		<a class="item" target="_blank" rel="noopener noreferrer" href="https://docs.gitea.io">{{.locale.Tr "help"}}</a>
-	{{end}}
+		{{if not .IsSigned}}
+			<a class="item" target="_blank" rel="noopener noreferrer" href="https://docs.gitea.io">{{.locale.Tr "help"}}</a>
+		{{end}}
+	</div>
 
 	<!-- the full dropdown menus -->
-	<div class="navbar-right">
+	<div class="navbar-right ui secondary menu">
 		{{if and .IsSigned .MustChangePassword}}
 			<div class="ui dropdown jump item" data-tooltip-content="{{.locale.Tr "user_profile_and_more"}}">
 				<span class="text gt-df gt-ac">
@@ -75,14 +76,14 @@
 			</div><!-- end dropdown avatar menu -->
 		{{else if .IsSigned}}
 			{{if EnableTimetracking}}
-			<a class="active-stopwatch-trigger item ui gt-mx-0{{if not .ActiveStopwatch}} gt-hidden{{end}}" href="{{.ActiveStopwatch.IssueLink}}" title="{{.locale.Tr "active_stopwatch"}}">
+			<a class="active-stopwatch-trigger item gt-mx-0{{if not .ActiveStopwatch}} gt-hidden{{end}}" href="{{.ActiveStopwatch.IssueLink}}" title="{{.locale.Tr "active_stopwatch"}}">
 				<div class="gt-relative">
 					{{svg "octicon-stopwatch"}}
 					<span class="header-stopwatch-dot"></span>
 				</div>
 				<span class="mobile-only gt-ml-3">{{.locale.Tr "active_stopwatch"}}</span>
 			</a>
-			<div class="active-stopwatch-popup tippy-target gt-p-3">
+			<div class="active-stopwatch-popup item tippy-target gt-p-3">
 				<div class="gt-df gt-ac">
 					<a class="stopwatch-link gt-df gt-ac" href="{{.ActiveStopwatch.IssueLink}}">
 						{{svg "octicon-issue-opened" 16 "gt-mr-3"}}
@@ -111,7 +112,7 @@
 			</div>
 			{{end}}
 
-			<a href="{{AppSubUrl}}/notifications" class="item not-mobile gt-mx-0" data-tooltip-content="{{.locale.Tr "notifications"}}" aria-label="{{.locale.Tr "notifications"}}">
+			<a class="item not-mobile gt-mx-0" href="{{AppSubUrl}}/notifications" data-tooltip-content="{{.locale.Tr "notifications"}}" aria-label="{{.locale.Tr "notifications"}}">
 				<div class="gt-relative">
 					{{svg "octicon-bell"}}
 					<span class="notification_count{{if not $notificationUnreadCount}} gt-hidden{{end}}">{{$notificationUnreadCount}}</span>
diff --git a/web_src/css/modules/navbar.css b/web_src/css/modules/navbar.css
index 07d27e50f6036..fbbe457c21597 100644
--- a/web_src/css/modules/navbar.css
+++ b/web_src/css/modules/navbar.css
@@ -1,6 +1,7 @@
 #navbar {
   display: flex;
   align-items: center;
+  justify-content: space-between;
   background: var(--color-nav-bg);
   border-bottom: 1px solid var(--color-secondary);
   margin: 0 !important;
@@ -12,20 +13,15 @@
   min-height: 48px;
 }
 
-#navbar-logo {
+#navbar .navbar-left,
+#navbar .navbar-right {
   margin: 0;
-  width: auto !important;
-}
-
-#navbar .navbar-left {
   display: flex;
   align-items: center;
 }
 
-#navbar .navbar-right {
-  width: 100%;
-  display: flex;
-  justify-content: flex-end;
+#navbar-logo {
+  margin: 0;
 }
 
 #navbar .item {
@@ -35,6 +31,7 @@
   padding-bottom: 3px;
   display: flex;
   justify-content: center;
+  width: auto;
 }
 
 #navbar a.item:hover,
@@ -42,10 +39,6 @@
   background: var(--color-nav-hover-bg);
 }
 
-#navbar .navbar-mobile-right {
-  margin-left: auto;
-}
-
 #navbar .secondary.menu > .item > .svg,
 #navbar .right.menu > .item > .svg {
   margin-right: 0;
@@ -67,16 +60,40 @@
   #navbar .navbar-left {
     flex: 1;
     display: flex;
+    justify-content: space-between;
+  }
+  #navbar .navbar-mobile-right {
+    display: flex;
+    margin-left: auto !important;
   }
   #navbar .navbar-mobile-right > .item {
     display: flex;
   }
   /* show items if the navbar is open */
+  #navbar.navbar-menu-open,
+  #navbar.navbar-menu-open .navbar-right {
+    flex-direction: column;
+  }
+  #navbar.navbar-menu-open .navbar-left {
+    display: flex;
+    flex-wrap: wrap;
+  }
   #navbar.navbar-menu-open .item {
     display: flex;
+    width: 100%;
   }
-  #navbar .navbar-right {
-    flex-direction: column;
+  #navbar.navbar-menu-open .navbar-left #navbar-logo {
+    justify-content: flex-start;
+    width: 50%;
+    min-height: 48px;
+  }
+  #navbar.navbar-menu-open .navbar-left .navbar-mobile-right {
+    justify-content: flex-end;
+    width: 50%;
+    min-height: 48px;
+  }
+  #navbar.navbar-menu-open .mobile-right-item {
+    width: auto !important;
   }
 }
 
@@ -87,10 +104,6 @@
   }
 }
 
-#navbar .navbar-mobile-right .item {
-  width: auto !important;
-}
-
 #navbar a.item .notification_count {
   color: var(--color-nav-bg);
   padding: 0 3.75px;
@@ -117,4 +130,5 @@
   display: flex;
   align-items: center;
   justify-content: center;
+  z-index: 1; /* prevent menu button background from overlaying icon */
 }

From 0f00707e3523408dd30c7d24bbe3af0b36f6eadc Mon Sep 17 00:00:00 2001
From: silverwind <me@silverwind.io>
Date: Tue, 20 Jun 2023 20:58:19 +0200
Subject: [PATCH 4/9] remove unused mobile-notifications-item

---
 templates/base/head_navbar.tmpl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/templates/base/head_navbar.tmpl b/templates/base/head_navbar.tmpl
index 23ea1cfa618a9..9523e3d293a06 100644
--- a/templates/base/head_navbar.tmpl
+++ b/templates/base/head_navbar.tmpl
@@ -13,7 +13,7 @@
 		<!-- mobile right menu, it must be here because in mobile view, each item is a flex column, the first item is a full row column -->
 		<div class="ui secondary menu item navbar-mobile-right gt-gap-2">
 			{{if .IsSigned}}
-			<a class="item mobile-right-item mobile-notifications-item gt-mr-2 gt-p-3" href="{{AppSubUrl}}/notifications" data-tooltip-content="{{.locale.Tr "notifications"}}" aria-label="{{.locale.Tr "notifications"}}">
+			<a class="item mobile-right-item gt-mr-2 gt-p-3" href="{{AppSubUrl}}/notifications" data-tooltip-content="{{.locale.Tr "notifications"}}" aria-label="{{.locale.Tr "notifications"}}">
 				<div class="gt-relative">
 					{{svg "octicon-bell"}}
 					<span class="notification_count{{if not $notificationUnreadCount}} gt-hidden{{end}}">{{$notificationUnreadCount}}</span>

From f72b094b2dabb0bbe818183791276db80c4a459b Mon Sep 17 00:00:00 2001
From: silverwind <me@silverwind.io>
Date: Tue, 20 Jun 2023 20:59:22 +0200
Subject: [PATCH 5/9] Update templates/base/head_navbar.tmpl

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
---
 templates/base/head_navbar.tmpl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/templates/base/head_navbar.tmpl b/templates/base/head_navbar.tmpl
index 9523e3d293a06..3086e674fd621 100644
--- a/templates/base/head_navbar.tmpl
+++ b/templates/base/head_navbar.tmpl
@@ -7,7 +7,7 @@
 	<div class="navbar-left ui secondary menu">
 		<!-- the logo -->
 		<a class="item" id="navbar-logo" href="{{AppSubUrl}}/" aria-label="{{if .IsSigned}}{{.locale.Tr "dashboard"}}{{else}}{{.locale.Tr "home"}}{{end}}">
-			<img width="30" height="30" src="{{AssetUrlPrefix}}/img/logo.svg" alt="{{.locale.Tr "logo"}}" aria-hidden="true"/>
+			<img width="30" height="30" src="{{AssetUrlPrefix}}/img/logo.svg" alt="{{.locale.Tr "logo"}}" aria-hidden="true">
 		</a>
 
 		<!-- mobile right menu, it must be here because in mobile view, each item is a flex column, the first item is a full row column -->

From 02ce2071142e6649fbafbd483e404e1545f8a707 Mon Sep 17 00:00:00 2001
From: silverwind <me@silverwind.io>
Date: Tue, 20 Jun 2023 21:03:34 +0200
Subject: [PATCH 6/9] increase height by 1px, fix mobile padding-bottom

---
 web_src/css/modules/navbar.css | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/web_src/css/modules/navbar.css b/web_src/css/modules/navbar.css
index fbbe457c21597..afa03f1a7d10f 100644
--- a/web_src/css/modules/navbar.css
+++ b/web_src/css/modules/navbar.css
@@ -9,8 +9,9 @@
 }
 
 #navbar,
-#navbar .navbar-left {
-  min-height: 48px;
+#navbar .navbar-left,
+#navbar .navbar-right {
+  min-height: 49px; /* +1px border-bottom */
 }
 
 #navbar .navbar-left,
@@ -47,7 +48,6 @@
 @media (max-width: 767.98px) {
   #navbar {
     align-items: stretch;
-    padding-bottom: 8px;
   }
   /* hide all items */
   #navbar .item {
@@ -70,6 +70,9 @@
     display: flex;
   }
   /* show items if the navbar is open */
+  #navbar.navbar-menu-open {
+    padding-bottom: 8px;
+  }
   #navbar.navbar-menu-open,
   #navbar.navbar-menu-open .navbar-right {
     flex-direction: column;

From 556bc0e56ee0f794f547f9c60de9238ce8c5a8ae Mon Sep 17 00:00:00 2001
From: silverwind <me@silverwind.io>
Date: Tue, 20 Jun 2023 21:29:14 +0200
Subject: [PATCH 7/9] fix dropdown regression

---
 web_src/css/modules/navbar.css | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/web_src/css/modules/navbar.css b/web_src/css/modules/navbar.css
index afa03f1a7d10f..039507e5c0146 100644
--- a/web_src/css/modules/navbar.css
+++ b/web_src/css/modules/navbar.css
@@ -25,7 +25,8 @@
   margin: 0;
 }
 
-#navbar .item {
+#navbar .navbar-left > .item,
+#navbar .navbar-right > .item {
   min-height: 36px;
   min-width: 36px;
   padding-top: 3px;

From b0ec30edd8bf93f2693659ae241b25d726daa7b1 Mon Sep 17 00:00:00 2001
From: silverwind <me@silverwind.io>
Date: Tue, 20 Jun 2023 21:38:40 +0200
Subject: [PATCH 8/9] Revert "fix dropdown regression"

This reverts commit 556bc0e56ee0f794f547f9c60de9238ce8c5a8ae.
---
 web_src/css/modules/navbar.css | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/web_src/css/modules/navbar.css b/web_src/css/modules/navbar.css
index 039507e5c0146..afa03f1a7d10f 100644
--- a/web_src/css/modules/navbar.css
+++ b/web_src/css/modules/navbar.css
@@ -25,8 +25,7 @@
   margin: 0;
 }
 
-#navbar .navbar-left > .item,
-#navbar .navbar-right > .item {
+#navbar .item {
   min-height: 36px;
   min-width: 36px;
   padding-top: 3px;

From a47664fb7c62c6f01cdb1a1e06a856a77c2b27a4 Mon Sep 17 00:00:00 2001
From: silverwind <me@silverwind.io>
Date: Tue, 20 Jun 2023 21:48:15 +0200
Subject: [PATCH 9/9] better fixes

---
 web_src/css/modules/navbar.css | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/web_src/css/modules/navbar.css b/web_src/css/modules/navbar.css
index afa03f1a7d10f..abc6afc69037f 100644
--- a/web_src/css/modules/navbar.css
+++ b/web_src/css/modules/navbar.css
@@ -32,7 +32,6 @@
   padding-bottom: 3px;
   display: flex;
   justify-content: center;
-  width: auto;
 }
 
 #navbar a.item:hover,
@@ -65,9 +64,11 @@
   #navbar .navbar-mobile-right {
     display: flex;
     margin-left: auto !important;
+    width: auto !important;
   }
   #navbar .navbar-mobile-right > .item {
     display: flex;
+    width: auto !important;
   }
   /* show items if the navbar is open */
   #navbar.navbar-menu-open {