From 679cb7c8249a976046c1f3e627baa1b8b6c97ece Mon Sep 17 00:00:00 2001 From: silverwind Date: Sun, 30 Apr 2023 18:14:56 +0200 Subject: [PATCH 1/2] Skip known flaky `queue` tests on CI environment --- modules/queue/queue_channel_test.go | 4 ++++ modules/queue/unique_queue_disk_channel_test.go | 4 ++++ 2 files changed, 8 insertions(+) diff --git a/modules/queue/queue_channel_test.go b/modules/queue/queue_channel_test.go index 9b92398bacd96..f9dae742e29d3 100644 --- a/modules/queue/queue_channel_test.go +++ b/modules/queue/queue_channel_test.go @@ -4,6 +4,7 @@ package queue import ( + "os" "sync" "testing" "time" @@ -101,6 +102,9 @@ func TestChannelQueue_Batch(t *testing.T) { } func TestChannelQueue_Pause(t *testing.T) { + if os.Getenv("CI") != "" { + t.Skip("Skipping because test is flaky on CI") + } lock := sync.Mutex{} var queue Queue var err error diff --git a/modules/queue/unique_queue_disk_channel_test.go b/modules/queue/unique_queue_disk_channel_test.go index fd76163f4aaca..4d1be567c21be 100644 --- a/modules/queue/unique_queue_disk_channel_test.go +++ b/modules/queue/unique_queue_disk_channel_test.go @@ -4,6 +4,7 @@ package queue import ( + "os" "fmt" "strconv" "sync" @@ -16,6 +17,9 @@ import ( ) func TestPersistableChannelUniqueQueue(t *testing.T) { + if os.Getenv("CI") != "" { + t.Skip("Skipping because test is flaky on CI") + } tmpDir := t.TempDir() fmt.Printf("TempDir %s\n", tmpDir) _ = log.NewLogger(1000, "console", "console", `{"level":"warn","stacktracelevel":"NONE","stderr":true}`) From eaa033be5f5554cf33191e030d6b5a600ee3194d Mon Sep 17 00:00:00 2001 From: silverwind Date: Sun, 30 Apr 2023 18:29:04 +0200 Subject: [PATCH 2/2] make fmt --- modules/queue/unique_queue_disk_channel_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/queue/unique_queue_disk_channel_test.go b/modules/queue/unique_queue_disk_channel_test.go index 4d1be567c21be..7417d74c0b136 100644 --- a/modules/queue/unique_queue_disk_channel_test.go +++ b/modules/queue/unique_queue_disk_channel_test.go @@ -4,8 +4,8 @@ package queue import ( - "os" "fmt" + "os" "strconv" "sync" "testing"