From e67565db9030aee6ba05ffdf93ecdbbed13871a9 Mon Sep 17 00:00:00 2001 From: delvh Date: Fri, 24 Feb 2023 17:25:48 +0100 Subject: [PATCH 1/5] Improve accessibility for the global navbar Changes include - use ` diff --git a/web_src/js/features/.aria.js.swp b/web_src/js/features/.aria.js.swp new file mode 100644 index 0000000000000000000000000000000000000000..972e9591a078456f6bfa84bc87711c744fc47dd5 GIT binary patch literal 16384 zcmeHOO^h5z74A5J5JDgVA>{z5JXyJW$ZXF#fCTH^1!D)X4kj3{6Mlr&HQhBk?d|FA zbXD(oU%kJ2Rqw0yVCB)x)8a$niie+jJ?~d9z82kf??1d}U%cB(Ri4q;H~QJF232ON z8x8ZmNCNvii6JQ2pQypME~EYh-5)Axs#58`EE5@C&^MIT4ro2ldf*m3P?_QK2k-IT z_ux@p>i2gJi+8;J+${)bhqfMQJ z?)Pm6e&6msciiu~bEwC;uiIa(2U-ub9%wz#dZ6_{>w(q-tp{2Uv>s?Z(0ZWt!2h8K zWbAoIpw|^@^T7Q; z2YB@^&l>~3f0O6^4!8omANbjwo;Lv=1MUQ#ek0}whJXUj0PBDN{__Ut4!i*T0eBMF z1RerT0`~#`y~FeV1^g5E5%5jmBfx7QL;el?8h98u1-t?RwZx5li?hiLqE0OL3VOaX!hy`X7P6gXi?v?_Klpo=hv{ce}?tl9&udpu%0X zFV@%Bh5t}yROxrcC4SiNi;*f7B#LpRji|H|7)o;rwWl&825OjNK&^nU>3LO%k<8*$ zl|7LgNSGvek^TWuT4cH4X`F~86M0q6zlYhU*5z5?yIEmYpt@px0}5iyWoyIIFpnxN z2dN6BF=gP>UyCfu$Rv9zRytByEHgtcvER8-N!)k=hQbkzhB6a&B>S?*b|*%QBo1jD z448Y2_cD4}sBvNTg*Ii9?U1Ef8B)`F`EWgZsekv&B*!YN!eNrdfxjU_3Sg*J zsv@JH<1s<%8Tb~GWwt}EltxUH$drol0W%F{nhs>NEAW6c8Rrmbcy3M^r|;sa>_bds zm0j#kb+JH9p-&H%orb=TCOU!3#fOD&N@SE+6+YC^$SoU|D9?~H^MlvLVQXxn13w%k zajY_=+mR!4-^(l+O9Ll{d1b6PE38yQ{58<%IN}Sp1uhc=IjAaPX_TPQ!wCq%pfXA$ zP*GmS6c3Y&s47d!T5E8>b}>hp^T}yml&X-WA}co$i(o0Bkk}=&AXa`iR5BU`!8UwD z1E&ef5tyd(OnRnrpwhWzY9GQ1xeRL!6m|JYYxJOu`C-<9^(vfQ1$LS)t!U_S*%@e8 zNE6Z~ay{19J|!K>Jk|cH%TKExt(w_kBdLqLs0s}8DUE&i5U;Aa?+&IFD}=ypJ#zAq zRn(W%Bn8sR1|`WeTPlpuRZ-+6R)W}9CL}BH5`LDawWY^7Uz;zS<|0V*$#RN9mEx-y zb;DLA&7)^ZP){Hckt?)t8X;uM%v`oS2>O;|Oxi_h675piK~dUS6>D;%%bK7Vl*!JH zDp?|rvbE02d#{*K!9X!B1u{)*OwHP?*3bD-gepV@SC(Zyq4Frs75$S`dXdSQ+)H*S z-v`P}6r?qZ={X^_{4F^Ua4A{H#S-3ZEQPpnzULmWaCH%G$Ks}C)6`ahf`nO&2(YqH z16`r19nzhfw^p9!g?ttwQ0Zq~T>I*v*Acfwo35B7X$t#<9>HiU9U03-(K;`o&5G7C z3Js@3nWuGGUGJh+3Vfny4xXbczWUf*SMdDkca9ini$iQ+5Np9L4yN- zEl&0};5yO^MCgTdIAGOc=In5Z(O7Gchdlu{eI}_-Bv}k5@_?SWTm+10(hmYQOaq4vqVs zcNq!IJ%u}gN^&`$qm3NkOsX#8nBp%VMWATwMQM-&>=#zHDi>oK9eY z&1hOxhi6{(xf7TbM&B%~TXhQ51&MNP6NwVAI9gQj&{*zryJHUuR7**<^}L{+%9d{# z$Ed|3rL%C-#_M2|NlIC=LG#U_5U5mQS73(e;IxK zbHI;*?*q>Q9{_%c-u@DB3V0XrOZ4-<0Dca912_wu0X_x12e<>Ep8sj|_2+?C(ZfFl zw(q-uS*ZmA&(#gGj-H`9Ix5S zzz3;;b7&HC--Cvm$ch6)_@vs5u+0XJmFrh^-IkQ)voB92o_InWw&Vi-WkuuqU}koE zEQUz*LzS8%b(u9;$5A}w6XRL50g=f;y|WzK($)Q+oo&%zM^2JtqHhALJ?Of8D3;I& zN4takqSE#{0tf3&$6!_TpF(>$91p?%;6?B&#FS;=jKO2oFM_`)nHgz_CXgtFG+=!q z?ncmKl!~aY*zq4*V8ZC^?#PuXqhkA%P7-(e9cbE_W0=u^Whw%XhvuXwG%g2lxJMr} z7Ia=GB0Hi+i%$CEL~HbxZn{k);#~2mpST<_`XIcR#aUy|Y^>Sv^f$sVTuUz*xMW{;3~2LcRfTFEuL;M zuffSOKU?T7kibz-ua77i_TnqlMwUiD23|1mj}zGn+MS36h0B8Y)6*LVSnde)87iA( z57LU3>4H~y-5wY{&XKFE%T2z(?eTTwHw42$g;50D6$#x$Z6#v`;uGXWbBEFsD_vZo zQ9{MwltJmbep6=qg6|1?;=&nf2|=Bsi)CJInIGT-aU=1R5p+pS3voIdEzPpB%XVgB zlpCxWu*^u|T@hdquRD!p&5XrddV{*>>A@N$8tfRBr)KiAOF3GTRJMp(Qj(i-x)ZTY zKHW8e)WD4!(E^`e`9jE?yd}8=eqcY+fvAhQE1@}#zb+z+nSI;~&ekT91yhSYD0D+L_@E(T&ip`heYoo3CU a4XPh*E;}5)4i_q}-E4QKHoU_xd;bHsJz*CB literal 0 HcmV?d00001 From 029d79dff9d8a00dc661364abef54b5810b520e1 Mon Sep 17 00:00:00 2001 From: delvh Date: Fri, 24 Feb 2023 17:28:35 +0100 Subject: [PATCH 2/5] Remove accidentally committed swap file --- web_src/js/features/.aria.js.swp | Bin 16384 -> 0 bytes 1 file changed, 0 insertions(+), 0 deletions(-) delete mode 100644 web_src/js/features/.aria.js.swp diff --git a/web_src/js/features/.aria.js.swp b/web_src/js/features/.aria.js.swp deleted file mode 100644 index 972e9591a078456f6bfa84bc87711c744fc47dd5..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 16384 zcmeHOO^h5z74A5J5JDgVA>{z5JXyJW$ZXF#fCTH^1!D)X4kj3{6Mlr&HQhBk?d|FA zbXD(oU%kJ2Rqw0yVCB)x)8a$niie+jJ?~d9z82kf??1d}U%cB(Ri4q;H~QJF232ON z8x8ZmNCNvii6JQ2pQypME~EYh-5)Axs#58`EE5@C&^MIT4ro2ldf*m3P?_QK2k-IT z_ux@p>i2gJi+8;J+${)bhqfMQJ z?)Pm6e&6msciiu~bEwC;uiIa(2U-ub9%wz#dZ6_{>w(q-tp{2Uv>s?Z(0ZWt!2h8K zWbAoIpw|^@^T7Q; z2YB@^&l>~3f0O6^4!8omANbjwo;Lv=1MUQ#ek0}whJXUj0PBDN{__Ut4!i*T0eBMF z1RerT0`~#`y~FeV1^g5E5%5jmBfx7QL;el?8h98u1-t?RwZx5li?hiLqE0OL3VOaX!hy`X7P6gXi?v?_Klpo=hv{ce}?tl9&udpu%0X zFV@%Bh5t}yROxrcC4SiNi;*f7B#LpRji|H|7)o;rwWl&825OjNK&^nU>3LO%k<8*$ zl|7LgNSGvek^TWuT4cH4X`F~86M0q6zlYhU*5z5?yIEmYpt@px0}5iyWoyIIFpnxN z2dN6BF=gP>UyCfu$Rv9zRytByEHgtcvER8-N!)k=hQbkzhB6a&B>S?*b|*%QBo1jD z448Y2_cD4}sBvNTg*Ii9?U1Ef8B)`F`EWgZsekv&B*!YN!eNrdfxjU_3Sg*J zsv@JH<1s<%8Tb~GWwt}EltxUH$drol0W%F{nhs>NEAW6c8Rrmbcy3M^r|;sa>_bds zm0j#kb+JH9p-&H%orb=TCOU!3#fOD&N@SE+6+YC^$SoU|D9?~H^MlvLVQXxn13w%k zajY_=+mR!4-^(l+O9Ll{d1b6PE38yQ{58<%IN}Sp1uhc=IjAaPX_TPQ!wCq%pfXA$ zP*GmS6c3Y&s47d!T5E8>b}>hp^T}yml&X-WA}co$i(o0Bkk}=&AXa`iR5BU`!8UwD z1E&ef5tyd(OnRnrpwhWzY9GQ1xeRL!6m|JYYxJOu`C-<9^(vfQ1$LS)t!U_S*%@e8 zNE6Z~ay{19J|!K>Jk|cH%TKExt(w_kBdLqLs0s}8DUE&i5U;Aa?+&IFD}=ypJ#zAq zRn(W%Bn8sR1|`WeTPlpuRZ-+6R)W}9CL}BH5`LDawWY^7Uz;zS<|0V*$#RN9mEx-y zb;DLA&7)^ZP){Hckt?)t8X;uM%v`oS2>O;|Oxi_h675piK~dUS6>D;%%bK7Vl*!JH zDp?|rvbE02d#{*K!9X!B1u{)*OwHP?*3bD-gepV@SC(Zyq4Frs75$S`dXdSQ+)H*S z-v`P}6r?qZ={X^_{4F^Ua4A{H#S-3ZEQPpnzULmWaCH%G$Ks}C)6`ahf`nO&2(YqH z16`r19nzhfw^p9!g?ttwQ0Zq~T>I*v*Acfwo35B7X$t#<9>HiU9U03-(K;`o&5G7C z3Js@3nWuGGUGJh+3Vfny4xXbczWUf*SMdDkca9ini$iQ+5Np9L4yN- zEl&0};5yO^MCgTdIAGOc=In5Z(O7Gchdlu{eI}_-Bv}k5@_?SWTm+10(hmYQOaq4vqVs zcNq!IJ%u}gN^&`$qm3NkOsX#8nBp%VMWATwMQM-&>=#zHDi>oK9eY z&1hOxhi6{(xf7TbM&B%~TXhQ51&MNP6NwVAI9gQj&{*zryJHUuR7**<^}L{+%9d{# z$Ed|3rL%C-#_M2|NlIC=LG#U_5U5mQS73(e;IxK zbHI;*?*q>Q9{_%c-u@DB3V0XrOZ4-<0Dca912_wu0X_x12e<>Ep8sj|_2+?C(ZfFl zw(q-uS*ZmA&(#gGj-H`9Ix5S zzz3;;b7&HC--Cvm$ch6)_@vs5u+0XJmFrh^-IkQ)voB92o_InWw&Vi-WkuuqU}koE zEQUz*LzS8%b(u9;$5A}w6XRL50g=f;y|WzK($)Q+oo&%zM^2JtqHhALJ?Of8D3;I& zN4takqSE#{0tf3&$6!_TpF(>$91p?%;6?B&#FS;=jKO2oFM_`)nHgz_CXgtFG+=!q z?ncmKl!~aY*zq4*V8ZC^?#PuXqhkA%P7-(e9cbE_W0=u^Whw%XhvuXwG%g2lxJMr} z7Ia=GB0Hi+i%$CEL~HbxZn{k);#~2mpST<_`XIcR#aUy|Y^>Sv^f$sVTuUz*xMW{;3~2LcRfTFEuL;M zuffSOKU?T7kibz-ua77i_TnqlMwUiD23|1mj}zGn+MS36h0B8Y)6*LVSnde)87iA( z57LU3>4H~y-5wY{&XKFE%T2z(?eTTwHw42$g;50D6$#x$Z6#v`;uGXWbBEFsD_vZo zQ9{MwltJmbep6=qg6|1?;=&nf2|=Bsi)CJInIGT-aU=1R5p+pS3voIdEzPpB%XVgB zlpCxWu*^u|T@hdquRD!p&5XrddV{*>>A@N$8tfRBr)KiAOF3GTRJMp(Qj(i-x)ZTY zKHW8e)WD4!(E^`e`9jE?yd}8=eqcY+fvAhQE1@}#zb+z+nSI;~&ekT91yhSYD0D+L_@E(T&ip`heYoo3CU a4XPh*E;}5)4i_q}-E4QKHoU_xd;bHsJz*CB From b32f20ed1e36bc5904c9d65dd00da42fc7dfd3ec Mon Sep 17 00:00:00 2001 From: delvh Date: Fri, 24 Feb 2023 18:09:58 +0100 Subject: [PATCH 3/5] Transform buttons back into non-descriptive divs As you can see from this title, I am not happy about reverting it. See https://github.com/go-gitea/gitea/pull/23125#discussion_r1117281548 for the reason. --- templates/base/head_navbar.tmpl | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/templates/base/head_navbar.tmpl b/templates/base/head_navbar.tmpl index 9fe8dd48d7bb1..33a7d5bd1ae69 100644 --- a/templates/base/head_navbar.tmpl +++ b/templates/base/head_navbar.tmpl @@ -127,7 +127,7 @@ - + - + {{else}} {{.locale.Tr "help"}} From 2f90bb366ee22820fc3df9a8a976f4009104d979 Mon Sep 17 00:00:00 2001 From: delvh Date: Fri, 24 Feb 2023 18:16:38 +0100 Subject: [PATCH 4/5] Re-add missing tag --- templates/base/head_navbar.tmpl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/templates/base/head_navbar.tmpl b/templates/base/head_navbar.tmpl index 33a7d5bd1ae69..374c04448843a 100644 --- a/templates/base/head_navbar.tmpl +++ b/templates/base/head_navbar.tmpl @@ -150,7 +150,7 @@ - +
{{avatar $.Context .SignedUser 24 "tiny"}} {{.locale.Tr "user_profile_and_more"}} From ece526398c42451f8a907cc1ce044729ea0aab25 Mon Sep 17 00:00:00 2001 From: delvh Date: Fri, 24 Feb 2023 18:24:53 +0100 Subject: [PATCH 5/5] Remove "unnecessary" comment --- templates/base/head_navbar.tmpl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/templates/base/head_navbar.tmpl b/templates/base/head_navbar.tmpl index 374c04448843a..24b4e18fbff2e 100644 --- a/templates/base/head_navbar.tmpl +++ b/templates/base/head_navbar.tmpl @@ -121,7 +121,7 @@ {{svg "octicon-bell"}} - + {{$notificationUnreadCount}}