Skip to content

Fix 500 on PR files API #21602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lunny merged 5 commits into from
Oct 26, 2022
Merged

Fix 500 on PR files API #21602

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a941d34
Fix 500 on PR files API
qwerty287 Oct 26, 2022
bb48281
Merge branch 'main' into fix-pr-files
qwerty287 Oct 26, 2022
095f129
Merge branch 'main' into fix-pr-files
lunny Oct 26, 2022
e49ce2f
Update routers/api/v1/repo/pull.go
6543 Oct 26, 2022
4133d74
Update routers/api/v1/repo/pull.go
qwerty287 Oct 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion routers/api/v1/repo/pull.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1443,7 +1443,11 @@ func GetPullRequestFiles(ctx *context.APIContext) {
end = totalNumberOfFiles
}

apiFiles := make([]*api.ChangedFile, 0, end-start)
lenFiles := end-start
if lenFiles < 0 {
lenFiles = 0
}
apiFiles := make([]*api.ChangedFile, 0, lenFiles)
for i := start; i < end; i++ {
apiFiles = append(apiFiles, convert.ToChangedFile(diff.Files[i], pr.HeadRepo, endCommitID))
}
Expand Down