From a9f62b87a869475288fdd04ac71d4ccb8d2886e1 Mon Sep 17 00:00:00 2001 From: Shuanglei Tao Date: Fri, 23 Jun 2017 09:34:58 +0800 Subject: [PATCH] Fix: `http: multiple response.WriteHeader calls` We can't change the http status code here, because the response has been written. --- routers/repo/http.go | 1 - 1 file changed, 1 deletion(-) diff --git a/routers/repo/http.go b/routers/repo/http.go index 0bea513eff106..b7e83536ca324 100644 --- a/routers/repo/http.go +++ b/routers/repo/http.go @@ -381,7 +381,6 @@ func serviceRPC(h serviceHandler, service string) { cmd.Stderr = &stderr if err := cmd.Run(); err != nil { log.GitLogger.Error(2, "fail to serve RPC(%s): %v - %v", service, err, stderr) - h.w.WriteHeader(http.StatusInternalServerError) return } }