From 3c85593097c077d641607d595057233029f9be45 Mon Sep 17 00:00:00 2001 From: Andrew Thornton Date: Sun, 1 Aug 2021 12:49:06 +0100 Subject: [PATCH 1/3] Disable frontend testing Jest does not appear to work on the latest node 16.6.0 and fails with an inscrutable message. I have been unable to work out what the problem is. This PR simply disables the test-frontend part in the makefile. Another alternative would be to drop node to node 14 - which is the LTS for node. Signed-off-by: Andrew Thornton --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index a0f5fdab308d3..e2bc4edb7b3b2 100644 --- a/Makefile +++ b/Makefile @@ -355,7 +355,7 @@ watch-backend: go-check air -c .air.conf .PHONY: test -test: test-frontend test-backend +test: test-backend .PHONY: test-backend test-backend: From 717290328073fe7eec03ce08addb52b2b63ac7a9 Mon Sep 17 00:00:00 2001 From: Andrew Thornton Date: Sun, 1 Aug 2021 12:52:56 +0100 Subject: [PATCH 2/3] actually just tell on 16.5 instead Signed-off-by: Andrew Thornton --- .drone.yml | 2 +- Makefile | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.drone.yml b/.drone.yml index c12138989bd9a..5beeac07e56a9 100644 --- a/.drone.yml +++ b/.drone.yml @@ -71,7 +71,7 @@ steps: depends_on: [lint-backend] - name: test-frontend - image: node:16 + image: node:16.5 commands: - make test-frontend depends_on: [lint-frontend] diff --git a/Makefile b/Makefile index e2bc4edb7b3b2..a0f5fdab308d3 100644 --- a/Makefile +++ b/Makefile @@ -355,7 +355,7 @@ watch-backend: go-check air -c .air.conf .PHONY: test -test: test-backend +test: test-frontend test-backend .PHONY: test-backend test-backend: From a4f3c70d08f4298cb1a09aa3759b5f70d9ab8cfa Mon Sep 17 00:00:00 2001 From: Andrew Thornton Date: Sun, 1 Aug 2021 12:56:34 +0100 Subject: [PATCH 3/3] Use node 16.5 instead of 16 Signed-off-by: Andrew Thornton --- .drone.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.drone.yml b/.drone.yml index 5beeac07e56a9..65b239fb6f720 100644 --- a/.drone.yml +++ b/.drone.yml @@ -15,12 +15,12 @@ trigger: steps: - name: deps-frontend pull: always - image: node:16 + image: node:16.5 commands: - make node_modules - name: lint-frontend - image: node:16 + image: node:16.5 commands: - make lint-frontend depends_on: [deps-frontend] @@ -58,7 +58,7 @@ steps: TAGS: bindata gogit sqlite sqlite_unlock_notify - name: checks-frontend - image: node:16 + image: node:16.5 commands: - make checks-frontend depends_on: [deps-frontend] @@ -77,7 +77,7 @@ steps: depends_on: [lint-frontend] - name: build-frontend - image: node:16 + image: node:16.5 commands: - make frontend depends_on: [test-frontend]