From 05a11acd54df0bedad51668c9df10481b4d5a68c Mon Sep 17 00:00:00 2001 From: Norwin Roosen Date: Thu, 11 Mar 2021 10:44:30 +0100 Subject: [PATCH 1/3] fix no items under /org/$org/{issues,pulls}?type=mentioned it was filtering by org id, but org-mentions are not persisted like that to the DB, we need to filter by UID. This means, selecting different teams will only have an effect on the selected repos, otherwise results will be the same, which may be suboptimal. fixes #14941 --- routers/user/home.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/routers/user/home.go b/routers/user/home.go index 886c4ab1baaa2..096a081836d84 100644 --- a/routers/user/home.go +++ b/routers/user/home.go @@ -432,9 +432,9 @@ func buildIssueOverview(ctx *context.Context, unitType models.UnitType) { case models.FilterModeCreate: opts.PosterID = ctx.User.ID case models.FilterModeMention: - opts.MentionedID = ctxUser.ID + opts.MentionedID = ctx.User.ID case models.FilterModeReviewRequested: - opts.ReviewRequestedID = ctxUser.ID + opts.ReviewRequestedID = ctx.User.ID } if ctxUser.IsOrganization() { From 555ea833958c0054abc203709ee53c02ad2245b3 Mon Sep 17 00:00:00 2001 From: Norwin Roosen Date: Thu, 11 Mar 2021 10:44:52 +0100 Subject: [PATCH 2/3] don't spam a warning for a perfectly fine request --- routers/user/home.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/routers/user/home.go b/routers/user/home.go index 096a081836d84..5d39eda36d8de 100644 --- a/routers/user/home.go +++ b/routers/user/home.go @@ -712,6 +712,9 @@ func getRepoIDs(reposQuery string) []int64 { if len(reposQuery) == 0 { return []int64{} } + if reposQuery == "[]" { + return []int64{} + } if !issueReposQueryPattern.MatchString(reposQuery) { log.Warn("issueReposQueryPattern does not match query") return []int64{} From e5bc5d22d7f856d9bd04b6946bf336934c8f15ef Mon Sep 17 00:00:00 2001 From: 6543 <6543@obermui.de> Date: Fri, 12 Mar 2021 03:25:24 +0100 Subject: [PATCH 3/3] code format --- routers/user/home.go | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/routers/user/home.go b/routers/user/home.go index 5d39eda36d8de..24aaf00ba829e 100644 --- a/routers/user/home.go +++ b/routers/user/home.go @@ -709,10 +709,7 @@ func buildIssueOverview(ctx *context.Context, unitType models.UnitType) { } func getRepoIDs(reposQuery string) []int64 { - if len(reposQuery) == 0 { - return []int64{} - } - if reposQuery == "[]" { + if len(reposQuery) == 0 || reposQuery == "[]" { return []int64{} } if !issueReposQueryPattern.MatchString(reposQuery) {