From 34d66afb8009f82c708bd4696e490bdbefd55234 Mon Sep 17 00:00:00 2001 From: Cirno the Strongest <1447794+CirnoT@users.noreply.github.com> Date: Wed, 16 Dec 2020 17:00:46 +0100 Subject: [PATCH 1/2] Send webhook when tag is removed via Web UI (#14015) * Send webhook when tag is removed via Web UI * Stray code (cherry picked from commit 53308de0bf6880798666a98cbc2df6c7be527f50) --- services/release/release.go | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/services/release/release.go b/services/release/release.go index c36e2126ed782..72318d2fb7f8a 100644 --- a/services/release/release.go +++ b/services/release/release.go @@ -142,6 +142,15 @@ func DeleteReleaseByID(id int64, doer *models.User, delTag bool) error { return fmt.Errorf("git tag -d: %v", err) } + notification.NotifyPushCommits( + doer, repo, + &repository.PushUpdateOptions{ + RefFullName: git.TagPrefix + rel.TagName, + OldCommitID: rel.Sha1, + NewCommitID: git.EmptySHA, + }, repository.NewPushCommits()) + notification.NotifyDeleteRef(doer, repo, "tag", git.TagPrefix+rel.TagName) + if err := models.DeleteReleaseByID(id); err != nil { return fmt.Errorf("DeleteReleaseByID: %v", err) } From c40304425a6da70940efa0aa1324995db7081378 Mon Sep 17 00:00:00 2001 From: CirnoT <1447794+CirnoT@users.noreply.github.com> Date: Wed, 16 Dec 2020 17:41:04 +0100 Subject: [PATCH 2/2] Fix for 1.13 --- services/release/release.go | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/services/release/release.go b/services/release/release.go index 72318d2fb7f8a..82239420ca58b 100644 --- a/services/release/release.go +++ b/services/release/release.go @@ -143,12 +143,7 @@ func DeleteReleaseByID(id int64, doer *models.User, delTag bool) error { } notification.NotifyPushCommits( - doer, repo, - &repository.PushUpdateOptions{ - RefFullName: git.TagPrefix + rel.TagName, - OldCommitID: rel.Sha1, - NewCommitID: git.EmptySHA, - }, repository.NewPushCommits()) + doer, repo, git.TagPrefix+rel.TagName, rel.Sha1, git.EmptySHA, repository.NewPushCommits()) notification.NotifyDeleteRef(doer, repo, "tag", git.TagPrefix+rel.TagName) if err := models.DeleteReleaseByID(id); err != nil {