From df0bcefe696778a4d9e45cd6b24cfe08685eac9e Mon Sep 17 00:00:00 2001 From: Chris Shyi Date: Mon, 12 Oct 2020 17:10:49 +0800 Subject: [PATCH 1/9] Improve error feedback for duplicate deploy keys Instead of a generic HTTP 500 error page, a flash message is rendered with the deploy key page template so inform the user that a key with the intended title already exists. --- models/error.go | 2 +- routers/repo/setting.go | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/models/error.go b/models/error.go index 1cab19aafdb31..364924c996556 100644 --- a/models/error.go +++ b/models/error.go @@ -547,7 +547,7 @@ func IsErrDeployKeyNameAlreadyUsed(err error) bool { } func (err ErrDeployKeyNameAlreadyUsed) Error() string { - return fmt.Sprintf("public key already exists [repo_id: %d, name: %s]", err.RepoID, err.Name) + return fmt.Sprintf("public key with name already exists [repo_id: %d, name: %s]", err.RepoID, err.Name) } // _____ ___________ __ diff --git a/routers/repo/setting.go b/routers/repo/setting.go index ca222375fbec1..1b75522958f04 100644 --- a/routers/repo/setting.go +++ b/routers/repo/setting.go @@ -885,6 +885,9 @@ func DeployKeysPost(ctx *context.Context, form auth.AddKeyForm) { case models.IsErrKeyNameAlreadyUsed(err): ctx.Data["Err_Title"] = true ctx.RenderWithErr(ctx.Tr("repo.settings.key_name_used"), tplDeployKeys, &form) + case models.IsErrDeployKeyNameAlreadyUsed(err): + ctx.Data["Err_Title"] = true + ctx.RenderWithErr(ctx.Tr("repo.settings.key_name_used"), tplDeployKeys, &form) default: ctx.ServerError("AddDeployKey", err) } From c4341c2c58105ed8bb32fd512b0ad4bf9ebc6088 Mon Sep 17 00:00:00 2001 From: Chris Shyi Date: Mon, 12 Oct 2020 17:42:28 +0800 Subject: [PATCH 2/9] API returns 422 error when key with name exists --- routers/api/v1/repo/key.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/routers/api/v1/repo/key.go b/routers/api/v1/repo/key.go index 5d63a25d64ba9..3d16ae6d4055a 100644 --- a/routers/api/v1/repo/key.go +++ b/routers/api/v1/repo/key.go @@ -177,6 +177,8 @@ func HandleAddKeyError(ctx *context.APIContext, err error) { ctx.Error(http.StatusUnprocessableEntity, "", "Key content has been used as non-deploy key") case models.IsErrKeyNameAlreadyUsed(err): ctx.Error(http.StatusUnprocessableEntity, "", "Key title has been used") + case models.IsErrDeployKeyNameAlreadyUsed(err): + ctx.Error(http.StatusUnprocessableEntity, "", "A key with the same name already exists") default: ctx.Error(http.StatusInternalServerError, "AddKey", err) } From 1a539ef15a326b1604c98ceb7cbba3646e17351f Mon Sep 17 00:00:00 2001 From: Chris Shyi Date: Sun, 1 Nov 2020 20:29:53 +0800 Subject: [PATCH 3/9] Add email validity checking Add email validity checking for the following routes: [Web interface] 1. User registration 2. User creation by admin 3. Adding an email through user settings [API] 1. POST /admin/users 2. PATCH /admin/users/:username 3. POST /user/emails --- models/error.go | 15 +++++++++++++++ models/user.go | 26 ++++++++++++++++++++++++++ models/user_mail.go | 10 ++++++++++ models/user_test.go | 15 +++++++++++++++ options/locale/locale_en-US.ini | 1 + options/locale/locale_zh-TW.ini | 1 + routers/admin/users.go | 6 ++++++ routers/admin/users_test.go | 30 ++++++++++++++++++++++++++++++ routers/api/v1/admin/user.go | 3 ++- routers/api/v1/user/email.go | 4 ++++ routers/user/auth.go | 3 +++ 11 files changed, 113 insertions(+), 1 deletion(-) diff --git a/models/error.go b/models/error.go index b2273f74c91e1..83354ff173d55 100644 --- a/models/error.go +++ b/models/error.go @@ -193,6 +193,21 @@ func (err ErrEmailAlreadyUsed) Error() string { return fmt.Sprintf("e-mail already in use [email: %s]", err.Email) } +// ErrEmailInvalid represents an error where the email address does not comply with RFC 5322 +type ErrEmailInvalid struct { + Email string +} + +// IsErrEmailInvalid checks if an error is an ErrEmailInvalid +func IsErrEmailInvalid(err error) bool { + _, ok := err.(ErrEmailInvalid) + return ok +} + +func (err ErrEmailInvalid) Error() string { + return fmt.Sprintf("e-mail invalid [email: %s]", err.Email) +} + // ErrOpenIDAlreadyUsed represents a "OpenIDAlreadyUsed" kind of error. type ErrOpenIDAlreadyUsed struct { OpenID string diff --git a/models/user.go b/models/user.go index 42f70b4666ffe..9cc82892f0ff3 100644 --- a/models/user.go +++ b/models/user.go @@ -14,6 +14,7 @@ import ( "errors" "fmt" _ "image/jpeg" // Needed for jpeg support + "net/mail" "os" "path/filepath" "regexp" @@ -808,6 +809,11 @@ func CreateUser(u *User) (err error) { return ErrEmailAlreadyUsed{u.Email} } + _, err = mail.ParseAddress(u.Email) + if err != nil { + return ErrEmailInvalid{u.Email} + } + isExist, err = isEmailUsed(sess, u.Email) if err != nil { return err @@ -957,6 +963,26 @@ func updateUser(e Engine, u *User) error { // UpdateUser updates user's information. func UpdateUser(u *User) error { + sess := x.NewSession() + defer sess.Close() + if err := sess.Begin(); err != nil { + return err + } + + u.Email = strings.ToLower(u.Email) + isExist, err := sess. + Where("email=?", u.Email). + Get(new(User)) + if err != nil { + return err + } else if isExist { + return ErrEmailAlreadyUsed{u.Email} + } + + _, err = mail.ParseAddress(u.Email) + if err != nil { + return ErrEmailInvalid{u.Email} + } return updateUser(x, u) } diff --git a/models/user_mail.go b/models/user_mail.go index 60354e23ffb22..e15b5a3adfa96 100644 --- a/models/user_mail.go +++ b/models/user_mail.go @@ -8,6 +8,7 @@ package models import ( "errors" "fmt" + "net/mail" "strings" "code.gitea.io/gitea/modules/log" @@ -143,6 +144,11 @@ func addEmailAddress(e Engine, email *EmailAddress) error { return ErrEmailAlreadyUsed{email.Email} } + _, err = mail.ParseAddress(email.Email) + if err != nil { + return ErrEmailInvalid{email.Email} + } + _, err = e.Insert(email) return err } @@ -167,6 +173,10 @@ func AddEmailAddresses(emails []*EmailAddress) error { } else if used { return ErrEmailAlreadyUsed{emails[i].Email} } + _, err = mail.ParseAddress(emails[i].Email) + if err != nil { + return ErrEmailInvalid{emails[i].Email} + } } if _, err := x.Insert(emails); err != nil { diff --git a/models/user_test.go b/models/user_test.go index 7a6f5aa5122b7..216cd44c591d1 100644 --- a/models/user_test.go +++ b/models/user_test.go @@ -329,6 +329,21 @@ func TestCreateUser(t *testing.T) { assert.NoError(t, DeleteUser(user)) } +func TestCreateUserInvalidEmail(t *testing.T) { + user := &User{ + Name: "GiteaBot", + Email: "GiteaBot@gitea.io\r\n", + Passwd: ";p['////..-++']", + IsAdmin: false, + Theme: setting.UI.DefaultTheme, + MustChangePassword: false, + } + + err := CreateUser(user) + assert.Error(t, err) + assert.True(t, IsErrEmailInvalid(err)) +} + func TestCreateUser_Issue5882(t *testing.T) { // Init settings diff --git a/options/locale/locale_en-US.ini b/options/locale/locale_en-US.ini index 60557aea76417..2bb622babfb2e 100644 --- a/options/locale/locale_en-US.ini +++ b/options/locale/locale_en-US.ini @@ -366,6 +366,7 @@ org_name_been_taken = The organization name is already taken. team_name_been_taken = The team name is already taken. team_no_units_error = Allow access to at least one repository section. email_been_used = The email address is already used. +email_invalid = The email address is invalid. openid_been_used = The OpenID address '%s' is already used. username_password_incorrect = Username or password is incorrect. password_complexity = Password does not pass complexity requirements: diff --git a/options/locale/locale_zh-TW.ini b/options/locale/locale_zh-TW.ini index 4a58422727160..36b38f15f8c09 100644 --- a/options/locale/locale_zh-TW.ini +++ b/options/locale/locale_zh-TW.ini @@ -360,6 +360,7 @@ org_name_been_taken=組織名稱已被使用。 team_name_been_taken=團隊名稱已被使用。 team_no_units_error=請至少選擇一個儲存庫區域。 email_been_used=此電子信箱已被使用 +email_invalid=無效的電子信箱 openid_been_used=OpenID 位址 '%s' 已被使用。 username_password_incorrect=帳號或密碼不正確 password_complexity=密碼複雜度沒有通過以下的要求: diff --git a/routers/admin/users.go b/routers/admin/users.go index 9fb758621b0a0..4382ee3877f4e 100644 --- a/routers/admin/users.go +++ b/routers/admin/users.go @@ -129,6 +129,9 @@ func NewUserPost(ctx *context.Context, form auth.AdminCreateUserForm) { case models.IsErrEmailAlreadyUsed(err): ctx.Data["Err_Email"] = true ctx.RenderWithErr(ctx.Tr("form.email_been_used"), tplUserNew, &form) + case models.IsErrEmailInvalid(err): + ctx.Data["Err_Email"] = true + ctx.RenderWithErr(ctx.Tr("form.email_invalid"), tplUserNew, &form) case models.IsErrNameReserved(err): ctx.Data["Err_UserName"] = true ctx.RenderWithErr(ctx.Tr("user.form.name_reserved", err.(models.ErrNameReserved).Name), tplUserNew, &form) @@ -277,6 +280,9 @@ func EditUserPost(ctx *context.Context, form auth.AdminEditUserForm) { if models.IsErrEmailAlreadyUsed(err) { ctx.Data["Err_Email"] = true ctx.RenderWithErr(ctx.Tr("form.email_been_used"), tplUserEdit, &form) + } else if models.IsErrEmailInvalid(err) { + ctx.Data["Err_Email"] = true + ctx.RenderWithErr(ctx.Tr("form.email_invalid"), tplUserEdit, &form) } else { ctx.ServerError("UpdateUser", err) } diff --git a/routers/admin/users_test.go b/routers/admin/users_test.go index 2b36b45d49cdd..a282507f56b6c 100644 --- a/routers/admin/users_test.go +++ b/routers/admin/users_test.go @@ -87,3 +87,33 @@ func TestNewUserPost_MustChangePasswordFalse(t *testing.T) { assert.Equal(t, email, u.Email) assert.False(t, u.MustChangePassword) } + +func TestNewUserPost_InvalidEmail(t *testing.T) { + + models.PrepareTestEnv(t) + ctx := test.MockContext(t, "admin/users/new") + + u := models.AssertExistsAndLoadBean(t, &models.User{ + IsAdmin: true, + ID: 2, + }).(*models.User) + + ctx.User = u + + username := "gitea" + email := "gitea@gitea.io\r\n" + + form := auth.AdminCreateUserForm{ + LoginType: "local", + LoginName: "local", + UserName: username, + Email: email, + Password: "abc123ABC!=$", + SendNotify: false, + MustChangePassword: false, + } + + NewUserPost(ctx, form) + + assert.NotEmpty(t, ctx.Flash.ErrorMsg) +} diff --git a/routers/api/v1/admin/user.go b/routers/api/v1/admin/user.go index dc095f3a1351a..c4b52e4bd6378 100644 --- a/routers/api/v1/admin/user.go +++ b/routers/api/v1/admin/user.go @@ -101,6 +101,7 @@ func CreateUser(ctx *context.APIContext, form api.CreateUserOption) { models.IsErrEmailAlreadyUsed(err) || models.IsErrNameReserved(err) || models.IsErrNameCharsNotAllowed(err) || + models.IsErrEmailInvalid(err) || models.IsErrNamePatternNotAllowed(err) { ctx.Error(http.StatusUnprocessableEntity, "", err) } else { @@ -208,7 +209,7 @@ func EditUser(ctx *context.APIContext, form api.EditUserOption) { } if err := models.UpdateUser(u); err != nil { - if models.IsErrEmailAlreadyUsed(err) { + if models.IsErrEmailAlreadyUsed(err) || models.IsErrEmailInvalid(err) { ctx.Error(http.StatusUnprocessableEntity, "", err) } else { ctx.Error(http.StatusInternalServerError, "UpdateUser", err) diff --git a/routers/api/v1/user/email.go b/routers/api/v1/user/email.go index 07fcde625e735..d848f5e58d8d2 100644 --- a/routers/api/v1/user/email.go +++ b/routers/api/v1/user/email.go @@ -5,6 +5,7 @@ package user import ( + "fmt" "net/http" "code.gitea.io/gitea/models" @@ -78,6 +79,9 @@ func AddEmail(ctx *context.APIContext, form api.CreateEmailOption) { if err := models.AddEmailAddresses(emails); err != nil { if models.IsErrEmailAlreadyUsed(err) { ctx.Error(http.StatusUnprocessableEntity, "", "Email address has been used: "+err.(models.ErrEmailAlreadyUsed).Email) + } else if models.IsErrEmailInvalid(err) { + errMsg := fmt.Sprintf("Email address %s invalid", err.(models.ErrEmailInvalid).Email) + ctx.Error(http.StatusUnprocessableEntity, "", errMsg) } else { ctx.Error(http.StatusInternalServerError, "AddEmailAddresses", err) } diff --git a/routers/user/auth.go b/routers/user/auth.go index 32b031fc7417a..63a3dec5e7eab 100644 --- a/routers/user/auth.go +++ b/routers/user/auth.go @@ -1151,6 +1151,9 @@ func SignUpPost(ctx *context.Context, cpt *captcha.Captcha, form auth.RegisterFo case models.IsErrEmailAlreadyUsed(err): ctx.Data["Err_Email"] = true ctx.RenderWithErr(ctx.Tr("form.email_been_used"), tplSignUp, &form) + case models.IsErrEmailInvalid(err): + ctx.Data["Err_Email"] = true + ctx.RenderWithErr(ctx.Tr("form.email_invalid"), tplSignUp, &form) case models.IsErrNameReserved(err): ctx.Data["Err_UserName"] = true ctx.RenderWithErr(ctx.Tr("user.form.name_reserved", err.(models.ErrNameReserved).Name), tplSignUp, &form) From b40038895131b3c9f4f0eb4ae4e396a76882d160 Mon Sep 17 00:00:00 2001 From: Chris Shyi Date: Mon, 9 Nov 2020 11:31:16 +0800 Subject: [PATCH 4/9] Add further tests --- integrations/api_admin_test.go | 19 +++++++++++++++++++ integrations/signup_test.go | 22 ++++++++++++++++++++++ routers/user/setting/account.go | 5 +++++ 3 files changed, 46 insertions(+) diff --git a/integrations/api_admin_test.go b/integrations/api_admin_test.go index 9ff9d71493fab..80d6b52289542 100644 --- a/integrations/api_admin_test.go +++ b/integrations/api_admin_test.go @@ -144,3 +144,22 @@ func TestAPIListUsersNonAdmin(t *testing.T) { req := NewRequestf(t, "GET", "/api/v1/admin/users?token=%s", token) session.MakeRequest(t, req, http.StatusForbidden) } + +func TestAPICreateUserInvalidEmail(t *testing.T) { + defer prepareTestEnv(t)() + adminUsername := "user1" + session := loginUser(t, adminUsername) + token := getTokenForLoggedInUser(t, session) + urlStr := fmt.Sprintf("/api/v1/admin/users?token=%s", token) + req := NewRequestWithValues(t, "POST", urlStr, map[string]string{ + "email": "invalid_email@domain.com\r\n", + "full_name": "invalid user", + "login_name": "invalidUser", + "must_change_password": "true", + "password": "password", + "send_notify": "true", + "source_id": "0", + "username": "invalidUser", + }) + session.MakeRequest(t, req, http.StatusUnprocessableEntity) +} diff --git a/integrations/signup_test.go b/integrations/signup_test.go index 02262ec85372e..1dabf14c7b470 100644 --- a/integrations/signup_test.go +++ b/integrations/signup_test.go @@ -6,9 +6,12 @@ package integrations import ( "net/http" + "strings" "testing" "code.gitea.io/gitea/modules/setting" + "github.com/stretchr/testify/assert" + "github.com/unknwon/i18n" ) func TestSignup(t *testing.T) { @@ -28,3 +31,22 @@ func TestSignup(t *testing.T) { req = NewRequest(t, "GET", "/exampleUser") MakeRequest(t, req, http.StatusOK) } + +func TestSignupInvalidEmail(t *testing.T) { + defer prepareTestEnv(t)() + + setting.Service.EnableCaptcha = false + + req := NewRequestWithValues(t, "POST", "/user/sign_up", map[string]string{ + "user_name": "exampleUser", + "email": "exampleUser@example.com\r\n", + "password": "examplePassword!1", + "retype": "examplePassword!1", + }) + resp := MakeRequest(t, req, http.StatusOK) + htmlDoc := NewHTMLParser(t, resp.Body) + assert.Equal(t, + i18n.Tr("en", "form.email_invalid", nil), + strings.TrimSpace(htmlDoc.doc.Find(".ui.message").Text()), + ) +} diff --git a/routers/user/setting/account.go b/routers/user/setting/account.go index 99e20177bc986..9b72e2a31a23f 100644 --- a/routers/user/setting/account.go +++ b/routers/user/setting/account.go @@ -179,6 +179,11 @@ func EmailPost(ctx *context.Context, form auth.AddEmailForm) { ctx.RenderWithErr(ctx.Tr("form.email_been_used"), tplSettingsAccount, &form) return + } else if models.IsErrEmailInvalid(err) { + loadAccountData(ctx) + + ctx.RenderWithErr(ctx.Tr("form.email_invalid"), tplSettingsAccount, &form) + return } ctx.ServerError("AddEmailAddress", err) return From bfdb76c4e581821900c738271446103fd01bade2 Mon Sep 17 00:00:00 2001 From: Chris Shyi Date: Mon, 9 Nov 2020 12:05:20 +0800 Subject: [PATCH 5/9] Add signup email tests --- integrations/signup_test.go | 42 +++++++++++++++++++++++++------------ 1 file changed, 29 insertions(+), 13 deletions(-) diff --git a/integrations/signup_test.go b/integrations/signup_test.go index 1dabf14c7b470..5208a42ce5918 100644 --- a/integrations/signup_test.go +++ b/integrations/signup_test.go @@ -5,6 +5,7 @@ package integrations import ( + "fmt" "net/http" "strings" "testing" @@ -32,21 +33,36 @@ func TestSignup(t *testing.T) { MakeRequest(t, req, http.StatusOK) } -func TestSignupInvalidEmail(t *testing.T) { +func TestSignupEmail(t *testing.T) { defer prepareTestEnv(t)() setting.Service.EnableCaptcha = false - req := NewRequestWithValues(t, "POST", "/user/sign_up", map[string]string{ - "user_name": "exampleUser", - "email": "exampleUser@example.com\r\n", - "password": "examplePassword!1", - "retype": "examplePassword!1", - }) - resp := MakeRequest(t, req, http.StatusOK) - htmlDoc := NewHTMLParser(t, resp.Body) - assert.Equal(t, - i18n.Tr("en", "form.email_invalid", nil), - strings.TrimSpace(htmlDoc.doc.Find(".ui.message").Text()), - ) + tests := []struct { + email string + wantStatus int + wantMsg string + }{ + {"exampleUser@example.com\r\n", http.StatusOK, i18n.Tr("en", "form.email_invalid", nil)}, + {"exampleUser@example.com\r", http.StatusOK, i18n.Tr("en", "form.email_invalid", nil)}, + {"exampleUser@example.com\n", http.StatusOK, i18n.Tr("en", "form.email_invalid", nil)}, + {"exampleUser@example.com", http.StatusFound, ""}, + } + + for i, test := range tests { + req := NewRequestWithValues(t, "POST", "/user/sign_up", map[string]string{ + "user_name": fmt.Sprintf("exampleUser%d", i), + "email": test.email, + "password": "examplePassword!1", + "retype": "examplePassword!1", + }) + resp := MakeRequest(t, req, test.wantStatus) + if test.wantMsg != "" { + htmlDoc := NewHTMLParser(t, resp.Body) + assert.Equal(t, + test.wantMsg, + strings.TrimSpace(htmlDoc.doc.Find(".ui.message").Text()), + ) + } + } } From fb476e20a382450c21983fa490d4c68e7f131e5a Mon Sep 17 00:00:00 2001 From: Chris Shyi Date: Mon, 9 Nov 2020 12:40:36 +0800 Subject: [PATCH 6/9] Add email validity check for linking existing account --- routers/user/auth.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/routers/user/auth.go b/routers/user/auth.go index 63a3dec5e7eab..ba6420967f646 100644 --- a/routers/user/auth.go +++ b/routers/user/auth.go @@ -964,6 +964,9 @@ func LinkAccountPostRegister(ctx *context.Context, cpt *captcha.Captcha, form au case models.IsErrEmailAlreadyUsed(err): ctx.Data["Err_Email"] = true ctx.RenderWithErr(ctx.Tr("form.email_been_used"), tplLinkAccount, &form) + case models.IsErrEmailInvalid(err): + ctx.Data["Err_Email"] = true + ctx.RenderWithErr(ctx.Tr("form.email_invalid"), tplSignUp, &form) case models.IsErrNameReserved(err): ctx.Data["Err_UserName"] = true ctx.RenderWithErr(ctx.Tr("user.form.name_reserved", err.(models.ErrNameReserved).Name), tplLinkAccount, &form) From 3684d64bfdc36a016b2c1af14459b801f1861a48 Mon Sep 17 00:00:00 2001 From: Chris Shyi Date: Mon, 9 Nov 2020 14:02:46 +0800 Subject: [PATCH 7/9] Address PR comments --- models/user.go | 11 +---------- options/locale/locale_zh-TW.ini | 1 - 2 files changed, 1 insertion(+), 11 deletions(-) diff --git a/models/user.go b/models/user.go index 9cc82892f0ff3..02e23d3c77452 100644 --- a/models/user.go +++ b/models/user.go @@ -970,16 +970,7 @@ func UpdateUser(u *User) error { } u.Email = strings.ToLower(u.Email) - isExist, err := sess. - Where("email=?", u.Email). - Get(new(User)) - if err != nil { - return err - } else if isExist { - return ErrEmailAlreadyUsed{u.Email} - } - - _, err = mail.ParseAddress(u.Email) + _, err := mail.ParseAddress(u.Email) if err != nil { return ErrEmailInvalid{u.Email} } diff --git a/options/locale/locale_zh-TW.ini b/options/locale/locale_zh-TW.ini index 2b194b21ce79b..f96c2719df024 100644 --- a/options/locale/locale_zh-TW.ini +++ b/options/locale/locale_zh-TW.ini @@ -364,7 +364,6 @@ org_name_been_taken=組織名稱已被使用。 team_name_been_taken=團隊名稱已被使用。 team_no_units_error=請至少選擇一個儲存庫區域。 email_been_used=此電子信箱已被使用 -email_invalid=無效的電子信箱 openid_been_used=OpenID 位址 '%s' 已被使用。 username_password_incorrect=帳號或密碼不正確 password_complexity=密碼複雜度沒有通過以下的要求: From 19d300359603ef256ec4fb3499f683e467a48ee2 Mon Sep 17 00:00:00 2001 From: Chris Shyi Date: Mon, 9 Nov 2020 15:34:55 +0800 Subject: [PATCH 8/9] Remove unneeded DB session --- models/user.go | 6 ------ 1 file changed, 6 deletions(-) diff --git a/models/user.go b/models/user.go index 02e23d3c77452..1e13f8489bd25 100644 --- a/models/user.go +++ b/models/user.go @@ -963,12 +963,6 @@ func updateUser(e Engine, u *User) error { // UpdateUser updates user's information. func UpdateUser(u *User) error { - sess := x.NewSession() - defer sess.Close() - if err := sess.Begin(); err != nil { - return err - } - u.Email = strings.ToLower(u.Email) _, err := mail.ParseAddress(u.Email) if err != nil { From 24ecaba0757375b9c863c328a8520433bbe26c5f Mon Sep 17 00:00:00 2001 From: Chris Shyi Date: Wed, 11 Nov 2020 09:37:53 +0800 Subject: [PATCH 9/9] Move email check to updateUser --- models/user.go | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/models/user.go b/models/user.go index 1e13f8489bd25..9489ff4e8bb58 100644 --- a/models/user.go +++ b/models/user.go @@ -957,17 +957,17 @@ func checkDupEmail(e Engine, u *User) error { } func updateUser(e Engine, u *User) error { - _, err := e.ID(u.ID).AllCols().Update(u) - return err -} - -// UpdateUser updates user's information. -func UpdateUser(u *User) error { u.Email = strings.ToLower(u.Email) _, err := mail.ParseAddress(u.Email) if err != nil { return ErrEmailInvalid{u.Email} } + _, err = e.ID(u.ID).AllCols().Update(u) + return err +} + +// UpdateUser updates user's information. +func UpdateUser(u *User) error { return updateUser(x, u) }