-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
LICENSE texts are are not correctly formatted #5552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hmm... I'm not sure that the formatting is necessarily incorrect. All of the other licenses in |
It may not be technically incorrect, but it is hard to read for humans and I don't see any advantage. |
@zeripath this is the script that pulls the latest license files from the SPDX repo: gitea/scripts/generate-licenses.go Line 20 in 801843b
|
Heya @tastytea , so the issue with the url is coming from our upstream ( https://github.com/spdx/license-list-data ) - please could you open an issue there? They've changed their formatting to match your preferred style - which I agree is nicer - so I've run our update script ( |
I've reported the issue upstream. |
Closing this issue as PR has been merged. |
Description
When I add a new repository and select a license, the LICENSE file is missing space and double-newlines, at least for GPL-2.0-only, GPL-3.0-only, GPL-3.0-or-later and BSD-4-Clause.
The GPL-3.0 licenses are also having a corrupted URL in line 3.
Correctly formatted GPL-3.0 license: https://www.gnu.org/licenses/gpl-3.0.txt
Screenshots
The text was updated successfully, but these errors were encountered: