Skip to content

FR: Create pull request comment via API #5060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
marvincaspar opened this issue Oct 10, 2018 · 7 comments
Closed

FR: Create pull request comment via API #5060

marvincaspar opened this issue Oct 10, 2018 · 7 comments
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented modifies/api This PR adds API routes or modifies them type/feature Completely new functionality. Can only be merged if feature freeze is not active.

Comments

@marvincaspar
Copy link

Description

In our CI/CD pipeline we use a static code analysis and I want to create a job, which creates comments on a pull request file if there is a code smell.

I didn't find any API call for this action.

@lunny lunny added type/feature Completely new functionality. Can only be merged if feature freeze is not active. modifies/api This PR adds API routes or modifies them labels Oct 10, 2018
@jmls
Copy link

jmls commented Oct 15, 2018

On a more general note - surely it would be better practice to "eat your own dog food" and make the gitea UI only use publicly available api calls ? That way any shortcomings in the api would be exposed very quickly.

There are several instances where the api does not have the same functionality as the UI - yet the UI has to be calling some rest endpoint

@stale
Copy link

stale bot commented Jan 6, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale stale bot added the issue/stale label Jan 6, 2019
@andrzejressel
Copy link
Contributor

andrzejressel commented Jan 12, 2019

@mc388 You can use issue comment api for that: https://try.gitea.io/api/swagger#/issue/issueCreateComment

I've just checked that and it works fine.

@stale stale bot removed the issue/stale label Jan 12, 2019
@lunny
Copy link
Member

lunny commented Jan 16, 2019

@jereksel I think he means comment on code lines on pull request review.

@marvincaspar
Copy link
Author

Thats right @lunny

@stale
Copy link

stale bot commented Mar 17, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale stale bot added the issue/stale label Mar 17, 2019
@lunny lunny added issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented and removed issue/stale labels Mar 17, 2019
@6543
Copy link
Member

6543 commented Nov 5, 2019

@marvincaspar can we close this in faifour of #5733

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented modifies/api This PR adds API routes or modifies them type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Development

No branches or pull requests

5 participants