Skip to content

Proposal: quick compare buttons at branch list #4547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SagePtr opened this issue Jul 29, 2018 · 2 comments · Fixed by #6990
Closed

Proposal: quick compare buttons at branch list #4547

SagePtr opened this issue Jul 29, 2018 · 2 comments · Fixed by #6990
Labels
type/feature Completely new functionality. Can only be merged if feature freeze is not active. type/proposal The new feature has not been accepted yet but needs to be discussed first.
Milestone

Comments

@SagePtr
Copy link
Contributor

SagePtr commented Jul 29, 2018

  • Gitea version (or commit ref): any
  • Git version: any
  • Operating system: any
  • Database: any
  • Can you reproduce the bug at https://try.gitea.io: no (server down)

Description

On /{user}/{repo}/branches page, there is brief list of branches.

Github shows compare button or pull request link for each non-default branch, which compares branch to default branch (usually master) and proposes to create Pull request (or links to pull request itself).

This functionality is missing in gitea. Would be good to implement this in gitea.

Screenshots

@techknowlogick techknowlogick added type/proposal The new feature has not been accepted yet but needs to be discussed first. type/feature Completely new functionality. Can only be merged if feature freeze is not active. labels Jul 29, 2018
@SagePtr
Copy link
Contributor Author

SagePtr commented Jul 29, 2018

To person who will edit template file (repos/branch/list.tmpl):
This part looks misaligned:

<td>
{{if .IsDeleted}}
	<s><a href="{{$.RepoLink}}/src/branch/{{.Name}}">{{.Name}}</a></s>
	<p class="time">{{$.i18n.Tr "repo.branch.deleted_by" .DeletedBranch.DeletedBy.Name}} {{TimeSinceUnix .DeletedBranch.DeletedUnix $.i18n.Lang}}</p>
{{else}}
	<a href="{{$.RepoLink}}/src/branch/{{.Name}}">{{.Name}}</a>
	<p class="time">{{$.i18n.Tr "org.repo_updated"}} {{TimeSince .Commit.Committer.When $.i18n.Lang}}</p>
</td>
{{end}}

</td> and {{end}} must swap places (not critical because closing </td> could be omited)

@ghost
Copy link

ghost commented Jul 31, 2018

Related: #3683 #4567

@lunny lunny added this to the 1.9.0 milestone Jun 27, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type/feature Completely new functionality. Can only be merged if feature freeze is not active. type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants