Ramdom users can be added as reviewers via API, while not via UI

[AdamMajer]

Feature Description

I'm not certain if this is a bug, a feature request or a UI issue.

I would like to add a review that is not a collaborator or member of organization. In the UI, I cannot seem to be able to add them. For example, to

https://demo.gitea.com/test2/repo/pulls/1

I can't add a user "gnuman". But programatically via API this works.

curl -X 'POST' 'https://demo.gitea.com/api/v1/repos/test2/repo/pulls/1/requested_reviewers' ....

Would it be possible to add explicit users to reviews outside of the teams/org? For example, typing a username in the UI should allow that user to be added even if we do not auto-complete users outside of the organizations.

Screenshots

[wxiaoguang]

IIRC it is by design ..... the reviewers could only be chosen from the candidate list.

The candidate list is constructed by GetReviewers and GetReviewerTeams (with various permission checks)

So if you'd like to relax the check, that would be a new design.

[wxiaoguang]

I can't add a user "gnuman". But programatically via API this works.
curl -X 'POST' 'https://demo.gitea.com/api/v1/repos/test2/repo/pulls/1/requested_reviewers' ....

Maybe there are some inconsistent logics between the API and Web UI (well, it happened a lot ...... bug)

[AdamMajer]

I've just tried this on github, and I also cannot add individual outside of the target organization.. So, yes, I think this can be re-classified as a bug in API then.

[lunny]

I believe the issue is that review requests from unrestricted users cannot be added through the UI, but can still be added via the API. #32642 will fix that.