Code review comment line number problem.

[lunny]

When comment on a previous commit of a pull request, the comment is in line number 39

But after two new commits pushed, the comment haven't been marked as outdated or hidden. The line number is still line 39 but now it should be line 58.

[yp05327]

Can you provide the URL of these screenshots.

[lunny]

https://gitea.com/gitea/blog/pulls/367/files

[metiftikci]

related to #21113 ?

[lunny]

Maybe different because there is no force push on https://gitea.com/gitea/blog/pulls/367/files

[skarndev]

I am also experiencing this issue

[yp05327]

This is because line is hard coded in DB, and this should be calculated dynamically.

So I think we need to consider a new flag (or generate from existing fields) to record the line.

[lunny]

Looks like they are two parts. In the conversations of pull request, Github will always display the line number in that commit. Gitea has the same implementation as Github.

But in the files tab, Github will recalculate the line numbers once new commit pushed. And in the current Gitea's implementation, it seems old commit comments will not be displayed?