Incorrect link for submodules that specify the remote port

[Governa]

• Gitea version (or commit ref):
  d4c9399 and any older one that I've tested
• Operating system: Ubuntu 16.04 (using the docker image)
• Database (use [x]):
  • PostgreSQL
  • MySQL
  • MSSQL
  • SQLite
• Can you reproduce the bug at https://try.gitea.io:
  • Yes (provide example URL)
    https://try.gitea.io/BugReproduction871239/test213
  • No
  • Not relevant
• Log gist:

Description

In the example URL, there is a submodule called test214 that uses the port (22) as user name in its link.
The submodule configuration is valid and works on the command line.

[Governa]

This one (superficially) seems to be pretty simple. If anyone can point me to the right direction I could solve it myself.

[thehowl]

The culprit should be this function here: https://github.com/go-gitea/git/blob/master/submodule.go#L32-L74 Have fun! If you need any help, come on #develop on the Discord server or #gitea-dev on Freenode :)

[Governa]

Hi,

Is this fix on the Docker image already? I've tested commit "da1edbf" here and it doesn't seems to solve the problem. Is there anything I should do to "update" the links?

[lunny]

This has been merged to latest Docker image I think.

[Governa]

The problem persists. The submodule link shows http(s)://<url>/<port>/<repo> instead of http(s)://<url>:<port>/<repo>.

The workaround I'm using is to set a relative path on the submodule URL. Fortunately, the workaround is the correct way of doing things 👍, but older revisions still have the wrong link.