Skip to content

Wrong avatars for authors in Commits tab #2457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mmarif4u opened this issue Sep 3, 2017 · 16 comments · Fixed by #7133
Closed

Wrong avatars for authors in Commits tab #2457

mmarif4u opened this issue Sep 3, 2017 · 16 comments · Fixed by #7133
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/bug
Milestone

Comments

@mmarif4u
Copy link

mmarif4u commented Sep 3, 2017

  • Gitea version (or commit ref): 04ec795

Screenshots:

selection_001

selection_002

@mmarif4u
Copy link
Author

mmarif4u commented Sep 3, 2017

Just to add:

  • Clicking on individual commit hash under Commits tab also show the default site avatar.
    selection_003
  • Also shows the same avatar on dashboard page in front of commits. Not sure what icon should it show.
    selection_004

@lafriks lafriks added this to the 1.x.x milestone Sep 3, 2017
@sapk
Copy link
Member

sapk commented Sep 8, 2017

Are you sure you commit with the good email ? You can see it executing git log in the repo.

@mmarif4u
Copy link
Author

mmarif4u commented Sep 8, 2017

@sapk that would be the case for local pushes if email does not match. But all this is done on the web interface, no local system push/pull involved, which made me open this issue.

@ethantkoenig
Copy link
Member

@mmarif4u A few questions to help us debug:

  1. Have you set DISABLE_GRAVATAR to false in app.ini?
  2. Do you see any error messages in the log (specifically this message)?
  3. Can you provide steps to reproduce?

@mmarif4u
Copy link
Author

@ethantkoenig

  1. It was set to true, even setting it to false has no effect.
  2. Nope, nothing related to it in the log, gitea.log.
2017/09/11 22:04:22 [I] Log Mode: File(Trace)
2017/09/11 22:04:22 [I] XORM Log Mode: File(Trace)
2017/09/11 22:04:22 [I] Cache Service Enabled
2017/09/11 22:04:22 [I] Session Service Enabled
2017/09/11 22:04:22 [I] Git Version: 2.7.4
2017/09/11 22:04:22 [T] Doing: CheckRepoStats
2017/09/11 22:04:22 [T] Doing: ArchiveCleanup
2017/09/11 22:04:22 [I] SQLite3 Supported
2017/09/11 22:04:22 [I] Run Mode: Production
2017/09/11 22:04:22 [I] Listen: http://0.0.0.0:3000
2017/09/11 22:04:22 [I] LFS server enabled
2017/09/11 22:04:26 [D] Session ID: 66231c453f1c4f54
2017/09/11 22:04:26 [D] CSRF Token: 6kVLqX0k5x9oDlC7MoHMW4juvxs6MTUwNTEzNzU0MDU2Mjg3NDUwMQ==
2017/09/11 22:04:26 [D] Detected encoding: utf-8 (fast)
2017/09/11 22:04:26 [D] Template: repo/diff/page
2017/09/11 22:04:28 [D] Session ID: 66231c453f1c4f54
2017/09/11 22:04:28 [D] CSRF Token: 6kVLqX0k5x9oDlC7MoHMW4juvxs6MTUwNTEzNzU0MDU2Mjg3NDUwMQ==
2017/09/11 22:04:28 [D] Detected encoding: utf-8 (fast)
2017/09/11 22:04:28 [D] Template: repo/diff/page
2017/09/11 22:04:31 [D] Session ID: 66231c453f1c4f54
2017/09/11 22:04:31 [D] CSRF Token: 6kVLqX0k5x9oDlC7MoHMW4juvxs6MTUwNTEzNzU0MDU2Mjg3NDUwMQ==
2017/09/11 22:04:31 [D] Template: repo/commits
2017/09/11 22:04:36 [D] Session ID: 66231c453f1c4f54
2017/09/11 22:04:36 [D] CSRF Token: 6kVLqX0k5x9oDlC7MoHMW4juvxs6MTUwNTEzNzU0MDU2Mjg3NDUwMQ==
2017/09/11 22:04:36 [D] Template: repo/home
2017/09/11 22:04:42 [D] Session ID: 66231c453f1c4f54
2017/09/11 22:04:42 [D] CSRF Token: 6kVLqX0k5x9oDlC7MoHMW4juvxs6MTUwNTEzNzU0MDU2Mjg3NDUwMQ==
2017/09/11 22:04:42 [D] Template: repo/home
2017/09/11 22:04:46 [D] Session ID: 66231c453f1c4f54
2017/09/11 22:04:46 [D] CSRF Token: 6kVLqX0k5x9oDlC7MoHMW4juvxs6MTUwNTEzNzU0MDU2Mjg3NDUwMQ==
2017/09/11 22:04:46 [D] Detected encoding: utf-8 (fast)
2017/09/11 22:04:46 [D] Template: repo/diff/page
2017/09/11 22:04:48 [D] Session ID: 66231c453f1c4f54
2017/09/11 22:04:48 [D] CSRF Token: 6kVLqX0k5x9oDlC7MoHMW4juvxs6MTUwNTEzNzU0MDU2Mjg3NDUwMQ==
2017/09/11 22:04:48 [D] Template: user/dashboard/dashboard
2017/09/11 22:04:49 [D] Session ID: 66231c453f1c4f54
2017/09/11 22:04:49 [D] CSRF Token: 6kVLqX0k5x9oDlC7MoHMW4juvxs6MTUwNTEzNzU0MDU2Mjg3NDUwMQ==
2017/09/11 22:07:29 [D] Session ID: 44ff8a43d258c2e6
2017/09/11 22:07:29 [D] CSRF Token: 2pmgXuIn4T2-_CrPzNnbCfM-oac6MTUwNTEzNjkzMDkyNjQ5MTk3NQ==
2017/09/11 22:07:29 [D] Template: user/dashboard/dashboard
2017/09/11 22:07:29 [D] Session ID: 44ff8a43d258c2e6
2017/09/11 22:07:29 [D] CSRF Token: 2pmgXuIn4T2-_CrPzNnbCfM-oac6MTUwNTEzNjkzMDkyNjQ5MTk3NQ==
2017/09/11 22:07:32 [D] Session ID: 44ff8a43d258c2e6
2017/09/11 22:07:32 [D] CSRF Token: 2pmgXuIn4T2-_CrPzNnbCfM-oac6MTUwNTEzNjkzMDkyNjQ5MTk3NQ==
2017/09/11 22:07:32 [D] Template: repo/home
2017/09/11 22:07:35 [D] Session ID: 44ff8a43d258c2e6
2017/09/11 22:07:35 [D] CSRF Token: 2pmgXuIn4T2-_CrPzNnbCfM-oac6MTUwNTEzNjkzMDkyNjQ5MTk3NQ==
2017/09/11 22:07:35 [D] Detected encoding: utf-8 (fast)
2017/09/11 22:07:35 [D] Template: repo/home
2017/09/11 22:07:37 [D] Session ID: 44ff8a43d258c2e6
2017/09/11 22:07:37 [D] CSRF Token: 2pmgXuIn4T2-_CrPzNnbCfM-oac6MTUwNTEzNjkzMDkyNjQ5MTk3NQ==
2017/09/11 22:07:37 [D] Detected encoding: utf-8 (fast)
2017/09/11 22:07:37 [D] Template: repo/editor/edit
2017/09/11 22:07:37 [D] Session ID: 44ff8a43d258c2e6
2017/09/11 22:07:37 [D] CSRF Token: 2pmgXuIn4T2-_CrPzNnbCfM-oac6MTUwNTEzNjkzMDkyNjQ5MTk3NQ==
2017/09/11 22:08:03 [D] Session ID: 44ff8a43d258c2e6
2017/09/11 22:08:03 [D] CSRF Token: 2pmgXuIn4T2-_CrPzNnbCfM-oac6MTUwNTEzNjkzMDkyNjQ5MTk3NQ==
2017/09/11 22:08:03 [T] TriggerTask 'website-revamp/dev' by mian
2017/09/11 22:08:03 [T] DeliverHooks [repo_id: 1]
2017/09/11 22:08:03 [T] AddTestPullRequestTask [head_repo_id: 1, head_branch: dev]: finding pull requests
2017/09/11 22:08:03 [T] AddTestPullRequestTask [base_repo_id: 1, base_branch: dev]: finding pull requests
2017/09/11 22:08:03 [D] Session ID: 44ff8a43d258c2e6
2017/09/11 22:08:03 [D] CSRF Token: 2pmgXuIn4T2-_CrPzNnbCfM-oac6MTUwNTEzNjkzMDkyNjQ5MTk3NQ==
2017/09/11 22:08:03 [D] Detected encoding: utf-8 (fast)
2017/09/11 22:08:03 [D] Template: repo/home
2017/09/11 22:08:06 [D] Session ID: 44ff8a43d258c2e6
2017/09/11 22:08:06 [D] CSRF Token: 2pmgXuIn4T2-_CrPzNnbCfM-oac6MTUwNTEzNjkzMDkyNjQ5MTk3NQ==
2017/09/11 22:08:06 [D] Template: user/dashboard/dashboard
2017/09/11 22:08:06 [D] Session ID: 44ff8a43d258c2e6
2017/09/11 22:08:06 [D] CSRF Token: 2pmgXuIn4T2-_CrPzNnbCfM-oac6MTUwNTEzNjkzMDkyNjQ5MTk3NQ==
2017/09/11 22:08:13 [D] Session ID: 44ff8a43d258c2e6
2017/09/11 22:08:13 [D] CSRF Token: 2pmgXuIn4T2-_CrPzNnbCfM-oac6MTUwNTEzNjkzMDkyNjQ5MTk3NQ==
2017/09/11 22:08:13 [D] Detected encoding: utf-8 (fast)
2017/09/11 22:08:13 [D] Template: repo/diff/page
  1. On the web interface, create a repo, create a file and commit it to the repo. Its the same for all users.

Its a local server on my machine.

@mmarif4u
Copy link
Author

I have installed it on a VPS having https via nginx proxy, still the same issue.

@lafriks
Copy link
Member

lafriks commented Oct 18, 2017

can you check in user table what is avatar guid for that user and check if file with such guid exists in avatar directory?

@mmarif4u
Copy link
Author

Yes, the user table avatar field have the guid for the user which match the filename in data/avatars.

@mmarif4u
Copy link
Author

Tested on another server and same problem.
This is happening on web interface of Gitea. Screens below.

User avatar:
selection_002

Repo:
selection_001

But if i push from my local machine with the same email, it shows the correct avatar.
selection_003

Which means that somehow email is missing or not passing when commit,merge happen on web.

@ntimo
Copy link

ntimo commented Jan 3, 2019

Is there any update on this? Would be awesome if the correct avatar would be shown, this always buggs me when I merge my branches via the webui.

@lunny
Copy link
Member

lunny commented Jan 5, 2019

@ntimo which version are you using?

@ntimo
Copy link

ntimo commented Jan 16, 2019

@lunny I am using version 1.7.0-rc2

@ntimo
Copy link

ntimo commented Jan 27, 2019

Also when changing code via the webui and committing it the wrong avatar is shown :(
Gitea version: 1.7.0

@sergey-dryabzhinsky
Copy link
Contributor

Can you provide part of output of git log with these commits - local and web?

@stale
Copy link

stale bot commented May 14, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale stale bot added the issue/stale label May 14, 2019
@lunny lunny added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label May 18, 2019
@stale
Copy link

stale bot commented Jun 1, 2019

This issue has been automatically closed because of inactivity. You can re-open it if needed.

@stale stale bot closed this as completed Jun 1, 2019
@lunny lunny removed the issue/stale label Jun 5, 2019
@lunny lunny reopened this Jun 5, 2019
@lunny lunny modified the milestones: 1.x.x, 1.9.0 Jun 6, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants