Skip to content

In the PR revew process, improve the presentation when a file is marked as viewed. #24250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JVC-MSF opened this issue Apr 21, 2023 · 2 comments
Closed

In the PR revew process, improve the presentation when a file is marked as viewed. #24250

JVC-MSF opened this issue Apr 21, 2023 · 2 comments
Labels
issue/duplicate The issue has already been reported.

Comments

@JVC-MSF
Copy link

JVC-MSF commented Apr 21, 2023

Feature Description

When I'm reviewing a PR, in the moment i click on the viewed checkbox in a file with a lot changes, the file is hidden but then I'm way down in the page and I must scroll up to reach the next file.

Will be nice if the page is scrolled to the begining of the next file when I click on the viewed checkbox of the current file.

Screenshots

No response
@JVC-MSF JVC-MSF added type/feature Completely new functionality. Can only be merged if feature freeze is not active. type/proposal The new feature has not been accepted yet but needs to be discussed first. labels Apr 21, 2023
@lunny
Copy link
Member

lunny commented Apr 23, 2023

This should be fixed by #23702

@JVC-MSF
Copy link
Author

JVC-MSF commented Apr 24, 2023

Cool! I see it's already merged.

Thanks!!

@delvh delvh closed this as completed Apr 24, 2023
@lunny lunny added issue/duplicate The issue has already been reported. and removed type/proposal The new feature has not been accepted yet but needs to be discussed first. type/feature Completely new functionality. Can only be merged if feature freeze is not active. labels Apr 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
issue/duplicate The issue has already been reported.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lunny @JVC-MSF @delvh