Skip to content

Web UI does not allow empty wiki pages, but does not notify about that #17280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
delvh opened this issue Oct 9, 2021 · 3 comments · Fixed by #17415
Closed

Web UI does not allow empty wiki pages, but does not notify about that #17280

delvh opened this issue Oct 9, 2021 · 3 comments · Fixed by #17415
Labels
topic/ui Change the appearance of the Gitea UI topic/wiki type/bug

Comments

@delvh
Copy link
Member

delvh commented Oct 9, 2021

Gitea Version

1.16.0+dev-339-gee73d8409

Operating System

Linux

Browser Version

Firefox 93

Can you reproduce the bug on the Gitea demo site?

Yes

Description

There seems to be a silent failure when attempting to publish a wiki page without content:
The save page button on the new page editor will simply act as if it was never pressed.
I think it would be better to notify the user that the content cannot be empty, just as the edit page editor does - yes, there is different behavior between the two.

Screenshots

No response

@delvh delvh added type/bug topic/ui Change the appearance of the Gitea UI labels Oct 9, 2021
@delvh
Copy link
Member Author

delvh commented Oct 9, 2021

Since when do we have a theme/wiki label? In a quick search prior today it was not present…

@zeripath
Copy link
Contributor

zeripath commented Oct 9, 2021

Since I added it for this one 🧙

@dvejmz
Copy link
Contributor

dvejmz commented Oct 23, 2021

I found a fix for this, will raise a PR shortly with more info.

@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
topic/ui Change the appearance of the Gitea UI topic/wiki type/bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants