Skip to content

FR: "Close with comment" instead of "close" for Issues #14407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pat-s opened this issue Jan 20, 2021 · 3 comments · Fixed by #14436
Closed

FR: "Close with comment" instead of "close" for Issues #14407

pat-s opened this issue Jan 20, 2021 · 3 comments · Fixed by #14436
Labels

Comments

@pat-s
Copy link
Member

pat-s commented Jan 20, 2021

I like how GitHub changes the "close" button in issues when there is content in the comment box from "close" to "close with comment".

No idea how hard that would be to implement in such a dynamic way but I got quite used to it lately and was unsure what would happen in Gitea if I entered a comment and hit the "close" button in the next step (which does the right thing, i.e. "close with comment").

image

@zeripath zeripath added type/feature Completely new functionality. Can only be merged if feature freeze is not active. good first issue Likely to be an easy fix labels Jan 20, 2021
@lunny lunny added type/proposal The new feature has not been accepted yet but needs to be discussed first. topic/ui Change the appearance of the Gitea UI labels Jan 21, 2021
@a1012112796
Copy link
Member

It's an exist feature, But seem has bug now..

gitea/web_src/js/index.js

Lines 1124 to 1132 in 1c230f6

// Change status
const $statusButton = $('#status-button');
$('#comment-form .edit_area').on('keyup', function () {
if ($(this).val().length === 0) {
$statusButton.text($statusButton.data('status'));
} else {
$statusButton.text($statusButton.data('status-and-comment'));
}
});

/cc @silverwind

@6543
Copy link
Member

6543 commented Jan 22, 2021

@pat-s witch version did you test?

@6543 6543 added type/bug and removed good first issue Likely to be an easy fix type/feature Completely new functionality. Can only be merged if feature freeze is not active. type/proposal The new feature has not been accepted yet but needs to be discussed first. topic/ui Change the appearance of the Gitea UI labels Jan 22, 2021
@pat-s
Copy link
Member Author

pat-s commented Jan 23, 2021

1.13.1

@go-gitea go-gitea locked and limited conversation to collaborators Mar 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants